extensions/common/url_pattern_set.h - Issue 377553003: Create a ManifestPermission implementation for Automation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/url_pattern_set.h

Issue 377553003: Create a ManifestPermission implementation for Automation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Remaining comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/manifest_handlers/automation.h ('K') | « extensions/common/permissions/permission_set.cc ('k') | extensions/common/url_pattern_set.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/url_pattern_set.h

diff --git a/extensions/common/url_pattern_set.h b/extensions/common/url_pattern_set.h

index b3116c8c231811c49448eb6a781227ddc6419e91..71358736471f12b13fa5b7f33b205c366096444c 100644

--- a/extensions/common/url_pattern_set.h

+++ b/extensions/common/url_pattern_set.h

@@ -79,6 +79,9 @@ class URLPatternSet {

// Test if the extent contains a URL.

bool MatchesURL(const GURL& url) const;

+ // Test if the extent matches all URLs (for example, <all_urls>)

Devlin 2014/07/21 23:43:53 nit: .

aboxhall 2014/07/22 17:00:09 Done.

+ bool MatchesAllURLs() const;

bool MatchesSecurityOrigin(const GURL& origin) const;

// Returns true if there is a single URL that would be in two extents.

@@ -91,6 +94,8 @@ class URLPatternSet {

bool allow_file_access,

std::string* error);

+ // Converts to and from a vector of strings.

+ scoped_ptr<std::vector<std::string> > ToStringVector() const;

bool Populate(const std::vector<std::string>& patterns,

int valid_schemes,

bool allow_file_access,