Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Unified Diff: extensions/common/url_pattern_set.h

Issue 377553003: Create a ManifestPermission implementation for Automation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Simplify AutomationInfo::Clone Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/url_pattern_set.h
diff --git a/extensions/common/url_pattern_set.h b/extensions/common/url_pattern_set.h
index b3116c8c231811c49448eb6a781227ddc6419e91..c68e01d41ccdc509a8c2e0b3cd69d97d5fe7bbd9 100644
--- a/extensions/common/url_pattern_set.h
+++ b/extensions/common/url_pattern_set.h
@@ -79,6 +79,8 @@ class URLPatternSet {
// Test if the extent contains a URL.
bool MatchesURL(const GURL& url) const;
+ bool MatchesAllURLs() const;
Devlin 2014/07/18 22:38:51 nit: comment
aboxhall 2014/07/21 22:44:10 Done.
+
bool MatchesSecurityOrigin(const GURL& origin) const;
// Returns true if there is a single URL that would be in two extents.
@@ -91,6 +93,8 @@ class URLPatternSet {
bool allow_file_access,
std::string* error);
+ // Converts to and from a vector of strings.
+ scoped_ptr<std::vector<std::string> > ToStringVector() const;
Devlin 2014/07/18 22:38:51 Put a new line between methods. And it's probably
aboxhall 2014/07/21 22:44:10 Actually I did it like this deliberately, to pair
Devlin 2014/07/21 23:43:52 Ah, I see. Okay, that makes sense, I guess.
bool Populate(const std::vector<std::string>& patterns,
int valid_schemes,
bool allow_file_access,

Powered by Google App Engine
This is Rietveld 408576698