Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 377523002: Only you can prevent memory leaks. (Closed)

Created:
6 years, 5 months ago by mtklein_C
Modified:
6 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Only you can prevent memory leaks. SkPaint::setFoo() refs the foo, leaving the foo with a bonus ref unless you call ->unref(). Valgrind caught this: http://108.170.220.120:10117/builders/Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind/builds/317/steps/RunTests/logs/stdio BUG=skia: Committed: https://skia.googlesource.com/skia/+/06d37714f722ff9e27fa31e243428afa86bf6bd3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/RecordTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
mtklein
6 years, 5 months ago (2014-07-07 13:20:53 UTC) #1
tomhudson
lgtm
6 years, 5 months ago (2014-07-07 13:39:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/377523002/1
6 years, 5 months ago (2014-07-07 13:40:25 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-07 14:00:21 UTC) #4
Message was sent while issue was closed.
Change committed as 06d37714f722ff9e27fa31e243428afa86bf6bd3

Powered by Google App Engine
This is Rietveld 408576698