Chromium Code Reviews

Issue 377513006: Fix several issues with ES6 redeclaration checks (Closed)

Created:
6 years, 5 months ago by rossberg
Modified:
6 years, 5 months ago
Reviewers:
ulan
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix several issues with ES6 redeclaration checks R=ulan@chromium.org BUG=v8:3426 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=22298

Patch Set 1 #

Total comments: 4

Patch Set 2 : Comments #

Unified diffs Side-by-side diffs Stats (+135 lines, -59 lines)
M src/parser.cc View 4 chunks +14 lines, -15 lines 0 comments
M test/mjsunit/harmony/block-conflicts.js View 3 chunks +94 lines, -38 lines 0 comments
M test/mjsunit/harmony/block-let-declaration.js View 2 chunks +24 lines, -2 lines 0 comments
A + test/mjsunit/harmony/regress/regress-3426.js View 1 chunk +2 lines, -3 lines 0 comments
M tools/generate-runtime-tests.py View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 4 (0 generated)
rossberg
6 years, 5 months ago (2014-07-07 16:08:22 UTC) #1
ulan
lgtm https://codereview.chromium.org/377513006/diff/1/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/377513006/diff/1/src/parser.cc#newcode1902 src/parser.cc:1902: // global scope, or the initial scope of ...
6 years, 5 months ago (2014-07-09 08:49:32 UTC) #2
rossberg
https://codereview.chromium.org/377513006/diff/1/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/377513006/diff/1/src/parser.cc#newcode1902 src/parser.cc:1902: // global scope, or the initial scope of another ...
6 years, 5 months ago (2014-07-09 11:30:41 UTC) #3
rossberg
6 years, 5 months ago (2014-07-09 11:35:13 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r22298 (presubmit successful).

Powered by Google App Engine