Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 377483002: Remove burst mode from VSyncMonitor. (Closed)

Created:
6 years, 5 months ago by egor.starkov
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove burst mode from VSyncMonitor. Extra vsyncs after each rendering cause 1% more power consumption. Modify VSyncMonitorTest to follow the rule 1 request == 1 vsync. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282154

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -38 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/VSyncMonitorTest.java View 1 6 chunks +13 lines, -18 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/VSyncMonitor.java View 1 6 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
egor.starkov
This patchset was reviewed here https://codereview.chromium.org/346813002/
6 years, 5 months ago (2014-07-07 10:59:33 UTC) #1
Sami
lgtm with a nit. https://codereview.chromium.org/377483002/diff/1/ui/android/java/src/org/chromium/ui/VSyncMonitor.java File ui/android/java/src/org/chromium/ui/VSyncMonitor.java (right): https://codereview.chromium.org/377483002/diff/1/ui/android/java/src/org/chromium/ui/VSyncMonitor.java#newcode138 ui/android/java/src/org/chromium/ui/VSyncMonitor.java:138: * Stop reporting vsync events. ...
6 years, 5 months ago (2014-07-07 14:35:06 UTC) #2
egor.starkov
https://codereview.chromium.org/377483002/diff/1/ui/android/java/src/org/chromium/ui/VSyncMonitor.java File ui/android/java/src/org/chromium/ui/VSyncMonitor.java (right): https://codereview.chromium.org/377483002/diff/1/ui/android/java/src/org/chromium/ui/VSyncMonitor.java#newcode138 ui/android/java/src/org/chromium/ui/VSyncMonitor.java:138: * Stop reporting vsync events. Note that at most ...
6 years, 5 months ago (2014-07-07 15:08:59 UTC) #3
Sami
On 2014/07/07 at 15:08:59, egor.starkov wrote: > I left it here because was afraid to ...
6 years, 5 months ago (2014-07-07 15:21:02 UTC) #4
egor.starkov
Removed empty method "stop()" in VSyncMonitor and tests.
6 years, 5 months ago (2014-07-07 16:03:10 UTC) #5
Sami
Thanks! lgtm.
6 years, 5 months ago (2014-07-07 16:20:29 UTC) #6
egor.starkov
The CQ bit was checked by egor.starkov@samsung.com
6 years, 5 months ago (2014-07-08 07:19:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/egor.starkov@samsung.com/377483002/20001
6 years, 5 months ago (2014-07-08 07:21:00 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 11:16:04 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 11:19:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/78462)
6 years, 5 months ago (2014-07-08 11:19:13 UTC) #11
egor.starkov
Adding OWNERS for review and LGTMing.
6 years, 5 months ago (2014-07-09 10:56:42 UTC) #12
Yaron
lgtm
6 years, 5 months ago (2014-07-09 20:53:00 UTC) #13
egor.starkov
The CQ bit was checked by egor.starkov@samsung.com
6 years, 5 months ago (2014-07-09 22:41:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/egor.starkov@samsung.com/377483002/20001
6 years, 5 months ago (2014-07-09 22:43:29 UTC) #15
commit-bot: I haz the power
Change committed as 282154
6 years, 5 months ago (2014-07-09 22:49:33 UTC) #16
egor.starkov
6 years, 5 months ago (2014-07-10 10:45:29 UTC) #17
Message was sent while issue was closed.
On 2014/07/09 20:53:00, Yaron wrote:
> lgtm

Thanks, Yaron!

Powered by Google App Engine
This is Rietveld 408576698