Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 377443007: fix WBMP image will get null color table when draw in RGB565 Canvas (Closed)

Created:
6 years, 5 months ago by djsollen
Modified:
6 years, 5 months ago
Reviewers:
scroggo, arthur_hung, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

fix WBMP image will get null color table when draw in RGB565 Canvas Symptom: draw Index8 to RGB565 will using SkColorTable::lock16BitCache and return a null array. Root Cause:lock16BitCache return null pointer because default type is kPremul_SkAlphaType Solution: WBMP color table should be kOpaque_SkAlphaType Reproduce steps: draw a WBMP with a matrix that apply rotate and transform This patch was proposed by arthur_hung at htc.com to the AOSP project. R=reed@google.com, scroggo@google.com Committed: https://skia.googlesource.com/skia/+/56a6b6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/images/SkImageDecoder_wbmp.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
djsollen
6 years, 5 months ago (2014-07-07 14:24:23 UTC) #1
reed1
lgtm
6 years, 5 months ago (2014-07-07 14:28:58 UTC) #2
scroggo
On 2014/07/07 14:28:58, reed1 wrote: > lgtm lgtm
6 years, 5 months ago (2014-07-07 14:31:11 UTC) #3
djsollen
6 years, 5 months ago (2014-07-08 12:23:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r56a6b6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698