Lots of random cleanups, mostly for native_theme_win.cc:

ui/views/controls/button/button.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/button.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "ui/accessibility/ax_view_state.h"
 
 namespace views {
 
 ////////////////////////////////////////////////////////////////////////////////
 // Button, static public:
 
 // static
 Button::ButtonState Button::GetButtonStateFrom(ui::NativeTheme::State state) {
   switch (state) {
     case ui::NativeTheme::kDisabled: return Button::STATE_DISABLED;
     case ui::NativeTheme::kHovered:  return Button::STATE_HOVERED;
     case ui::NativeTheme::kNormal:   return Button::STATE_NORMAL;
     case ui::NativeTheme::kPressed:  return Button::STATE_PRESSED;
-    case ui::NativeTheme::kMaxState: NOTREACHED() << "Unknown state: " << state;
+    default:                         NOTREACHED(); return Button::STATE_NORMAL;

[sky, 2014/07/10 16:05:39]

Same comment here about compile error.

[Peter Kasting, 2014/07/10 18:23:15]

See reply on other comment.

[Peter Kasting, 2014/07/10 21:44:25]

Changed this.

   }
-  return Button::STATE_NORMAL;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // Button, public:
 
 Button::~Button() {
 }
 
 void Button::SetTooltipText(const base::string16& tooltip_text) {
   tooltip_text_ = tooltip_text;
@@ skipping 33 matching lines @@
 }
 
 void Button::NotifyClick(const ui::Event& event) {
   // We can be called when there is no listener, in cases like double clicks on
   // menu buttons etc.
   if (listener_)
     listener_->ButtonPressed(this, event);
 }
 
 }  // namespace views