Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 377423002: Make ChromeAutofillClient a ZoomObserver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix typo in comment. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/autofill/chrome_autofill_client.cc ('k') | chrome/browser/ui/zoom/zoom_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/tab_helpers.cc
diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc
index a8d1d09311fa90c7e317240de89da569c4e5ac96..6e10af9f0aeeb99c19ddaf80913c05e0b1a106e0 100644
--- a/chrome/browser/ui/tab_helpers.cc
+++ b/chrome/browser/ui/tab_helpers.cc
@@ -112,6 +112,11 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {
// SessionTabHelper comes first because it sets up the tab ID, and other
// helpers may rely on that.
SessionTabHelper::CreateForWebContents(web_contents);
+#if !defined(OS_ANDROID)
+ // ZoomController comes before common tab helpers since ChromeAutofillClient
+ // may want to register as a ZoomObserver with it.
+ ZoomController::CreateForWebContents(web_contents);
+#endif
// --- Common tab helpers ---
@@ -164,7 +169,6 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {
TabContentsSyncedTabDelegate::CreateForWebContents(web_contents);
ThumbnailTabHelper::CreateForWebContents(web_contents);
web_modal::WebContentsModalDialogManager::CreateForWebContents(web_contents);
- ZoomController::CreateForWebContents(web_contents);
#endif
#if defined(OS_WIN)
« no previous file with comments | « chrome/browser/ui/autofill/chrome_autofill_client.cc ('k') | chrome/browser/ui/zoom/zoom_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698