[SyncFS] [Refactoring] Make interfaces to handle TrackerIDSet on DB

[SyncFS] [Refactoring]
Make interfaces to handle TrackerIDSet on DB.
Simulate behavior of TrackerIDSet to handle it easily.


BUG=None
TEST=./unit_tests --gtest_filter="MetadataDatabaseIndexOn*"

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282369

[peria, 2014-07-10 06:35:52]

PTL.

[tzik, 2014-07-10 06:39:33]

https://codereview.chromium.org/377413006/diff/40001/chrome/browser/sync_file...
File
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h
(right):

https://codereview.chromium.org/377413006/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h:102:
const std::string& active_key, const std::string& key_prefix) const;
s/active_key/active_item_key/ or active_tracker_key?

[tzik, 2014-07-10 06:49:35]

https://codereview.chromium.org/377413006/diff/40001/chrome/browser/sync_file...
File
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc
(right):

https://codereview.chromium.org/377413006/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:502:
GenerateActiveIDByFileIDKey(new_tracker.file_id()),
Could you rename this to GenerateActiveTrackerIDByFileIDKey?
"ActiveID" sounds a bit confusing.

https://codereview.chromium.org/377413006/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:664:
batch->Put(key_prefix + id_str, "");
We usually use std::string() instead of "" for empty string.
Could you replace it to keep them consistent?

https://codereview.chromium.org/377413006/diff/40001/chrome/browser/sync_file...
File
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h
(right):

https://codereview.chromium.org/377413006/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h:109:
void AddToTrackerIDSetByPrefix(
Maybe, s/By/With/?

[peria, 2014-07-10 07:49:08]

https://codereview.chromium.org/377413006/diff/40001/chrome/browser/sync_file...
File
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc
(right):

https://codereview.chromium.org/377413006/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:502:
GenerateActiveIDByFileIDKey(new_tracker.file_id()),
On 2014/07/10 06:49:34, tzik wrote:
> Could you rename this to GenerateActiveTrackerIDByFileIDKey?
> "ActiveID" sounds a bit confusing.

Done.

https://codereview.chromium.org/377413006/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:664:
batch->Put(key_prefix + id_str, "");
On 2014/07/10 06:49:35, tzik wrote:
> We usually use std::string() instead of "" for empty string.
> Could you replace it to keep them consistent?

Done.

https://codereview.chromium.org/377413006/diff/40001/chrome/browser/sync_file...
File
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h
(right):

https://codereview.chromium.org/377413006/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h:102:
const std::string& active_key, const std::string& key_prefix) const;
On 2014/07/10 06:39:33, tzik wrote:
> s/active_key/active_item_key/ or active_tracker_key?

Done.

https://codereview.chromium.org/377413006/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h:109:
void AddToTrackerIDSetByPrefix(
On 2014/07/10 06:49:35, tzik wrote:
> Maybe, s/By/With/?

Done.

[tzik, 2014-07-10 07:54:12]

lgtm

https://codereview.chromium.org/377413006/diff/60001/chrome/browser/sync_file...
File
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc
(right):

https://codereview.chromium.org/377413006/diff/60001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:700:
int64 active_id;
s/active_id/active_tracker_id/?

https://codereview.chromium.org/377413006/diff/60001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:721:
int64 active_id;
ditto

https://codereview.chromium.org/377413006/diff/60001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:736:
int64 active_id;
ditto

[peria, 2014-07-10 07:57:05]

https://codereview.chromium.org/377413006/diff/60001/chrome/browser/sync_file...
File
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc
(right):

https://codereview.chromium.org/377413006/diff/60001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:700:
int64 active_id;
On 2014/07/10 07:54:12, tzik wrote:
> s/active_id/active_tracker_id/?

Done.

https://codereview.chromium.org/377413006/diff/60001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:721:
int64 active_id;
On 2014/07/10 07:54:12, tzik wrote:
> ditto

Done.

https://codereview.chromium.org/377413006/diff/60001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:736:
int64 active_id;
On 2014/07/10 07:54:12, tzik wrote:
> ditto

Done.

[nhiroki, 2014-07-10 08:40:08]

https://codereview.chromium.org/377413006/diff/80001/chrome/browser/sync_file...
File
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc
(right):

https://codereview.chromium.org/377413006/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:504:
prefix, new_tracker, batch);
How about passing only |new_tracker| and creating a key and a prefix in the
function?

https://codereview.chromium.org/377413006/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:538:
new_tracker.tracker_id(), batch);
ditto.

https://codereview.chromium.org/377413006/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:542:
new_tracker.tracker_id(), batch);
ditto.

https://codereview.chromium.org/377413006/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:553:
tracker.tracker_id(), batch))
ditto.

[peria, 2014-07-10 09:07:20]

https://codereview.chromium.org/377413006/diff/80001/chrome/browser/sync_file...
File
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc
(right):

https://codereview.chromium.org/377413006/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:504:
prefix, new_tracker, batch);
On 2014/07/10 08:40:08, nhiroki wrote:
> How about passing only |new_tracker| and creating a key and a prefix in the
> function?

Those method will be used with other prefix/key pairs to indexing parent ID and
titles.

https://codereview.chromium.org/377413006/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:538:
new_tracker.tracker_id(), batch);
On 2014/07/10 08:40:08, nhiroki wrote:
> ditto.

Acknowledged.

https://codereview.chromium.org/377413006/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:542:
new_tracker.tracker_id(), batch);
On 2014/07/10 08:40:08, nhiroki wrote:
> ditto.

Acknowledged.

https://codereview.chromium.org/377413006/diff/80001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc:553:
tracker.tracker_id(), batch))
On 2014/07/10 08:40:08, nhiroki wrote:
> ditto.

Acknowledged.

[nhiroki, 2014-07-10 09:38:15]

Thanks for your explanation! LGTM

[peria, 2014-07-10 14:28:22]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-07-10 14:28:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/377413006/80001

[commit-bot: I haz the power, 2014-07-10 17:35:45]

Change committed as 282369