Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issue 377413003: Remove most remaining sync/notifier dependencies (Closed)

Created:
6 years, 5 months ago by rlarocque
Modified:
6 years, 5 months ago
Reviewers:
pavely
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove most remaining sync/notifier dependencies Removes most remaining dependencies from core sync/ files on sync/notifier/. There are some internal_api/public files that still reference sync/notifier. These will be dealt with after sync/notifer/ has been moved to components/invalidation/. BUG=259559 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282458

Patch Set 1 #

Patch Set 2 : Fix sync_client.cc #

Patch Set 3 : Attempt to fix win compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -105 lines) Patch
M chrome/browser/sync/glue/sync_backend_host_core.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/sync_scheduler_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sync/engine/sync_scheduler_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sync/internal_api/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/debug_info_event_listener.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/debug_info_event_listener.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M sync/internal_api/public/base/model_type_test_util.h View 1 chunk +0 lines, -16 lines 0 comments Download
M sync/internal_api/public/base/model_type_test_util.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M sync/internal_api/public/sync_manager.h View 2 chunks +1 line, -2 lines 0 comments Download
M sync/internal_api/public/test/fake_sync_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_manager_impl.h View 4 chunks +1 line, -6 lines 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 3 chunks +4 lines, -12 lines 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M sync/internal_api/sync_rollback_manager_base.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_rollback_manager_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/test/fake_sync_manager.cc View 2 chunks +1 line, -3 lines 0 comments Download
M sync/notifier/invalidation_handler.h View 1 2 3 chunks +5 lines, -1 line 0 comments Download
A + sync/notifier/invalidation_handler.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M sync/notifier/invalidator.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
A + sync/notifier/invalidator.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M sync/sessions/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M sync/sessions/nudge_tracker.h View 1 chunk +1 line, -0 lines 0 comments Download
M sync/sessions/nudge_tracker.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M sync/sessions/nudge_tracker_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M sync/sync_notifier.gypi View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M sync/tools/sync_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
rlarocque
Please review.
6 years, 5 months ago (2014-07-10 00:10:07 UTC) #1
pavely
lgtm
6 years, 5 months ago (2014-07-10 19:13:39 UTC) #2
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 5 months ago (2014-07-10 19:14:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/377413003/20001
6 years, 5 months ago (2014-07-10 19:17:03 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 19:59:45 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 20:18:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_dbg/builds/36902)
6 years, 5 months ago (2014-07-10 20:18:28 UTC) #7
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 5 months ago (2014-07-10 20:49:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/377413003/40001
6 years, 5 months ago (2014-07-10 20:50:37 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 23:26:42 UTC) #10
Message was sent while issue was closed.
Change committed as 282458

Powered by Google App Engine
This is Rietveld 408576698