Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 377403002: Move GN speechd target to third_party. (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
Henrik Grunell
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Move GN speechd target to third_party. The //build directory in GN shouldn't refer to anything outside of itself so that non-Chrome projects can copy it and re-use the build configuration. speechd relies on third_party/speech-dispatcher. This patch just moves the loader to the speech-dispatcher target, which makes more sense anyway. TBR=grunell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282138

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -24 lines) Patch
M build/config/linux/BUILD.gn View 1 chunk +1 line, -23 lines 0 comments Download
M build/linux/system.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A third_party/speech-dispatcher/BUILD.gn View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
6 years, 5 months ago (2014-07-09 19:45:38 UTC) #1
brettw
Since this is blocking the deps roll and won't get reviewed until tonight (my time), ...
6 years, 5 months ago (2014-07-09 22:05:42 UTC) #2
brettw
Committed patchset #1 manually as r282138 (presubmit successful).
6 years, 5 months ago (2014-07-09 22:12:01 UTC) #3
Henrik Grunell
6 years, 5 months ago (2014-07-10 06:45:05 UTC) #4
Message was sent while issue was closed.
I'm not the right person to review GN details, but on the other hand this is
just a move. LGTM.

Powered by Google App Engine
This is Rietveld 408576698