Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 377383007: Clip texts on drive banner using ellipsis. (Closed)

Created:
6 years, 5 months ago by fukino
Modified:
6 years, 5 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Clip texts on drive banner using ellipsis. BUG=390819 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282289

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M ui/file_manager/file_manager/foreground/css/drive_welcome.css View 2 chunks +7 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
fukino
@hirono - would you take a look? https://codereview.chromium.org/377383007/diff/1/ui/file_manager/file_manager/foreground/css/drive_welcome.css File ui/file_manager/file_manager/foreground/css/drive_welcome.css (right): https://codereview.chromium.org/377383007/diff/1/ui/file_manager/file_manager/foreground/css/drive_welcome.css#newcode99 ui/file_manager/file_manager/foreground/css/drive_welcome.css:99: flex: none; ...
6 years, 5 months ago (2014-07-10 01:06:45 UTC) #1
hirono
lgtm. Thank you!
6 years, 5 months ago (2014-07-10 02:09:08 UTC) #2
fukino
The CQ bit was checked by fukino@chromium.org
6 years, 5 months ago (2014-07-10 02:11:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/377383007/1
6 years, 5 months ago (2014-07-10 02:12:17 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 08:23:01 UTC) #5
Message was sent while issue was closed.
Change committed as 282289

Powered by Google App Engine
This is Rietveld 408576698