build/common.gypi - Issue 377383004: Enable _FORTIFY_SOURCE=2 with clang (unless sanitizers are used).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 377383004: Enable _FORTIFY_SOURCE=2 with clang (unless sanitizers are used). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@isystem

Patch Set: . Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 1d8d5af40fe75c498ddafecde2c0d086f495e1f8..0d7de665e68f1189988d186e6802ef23677dba79 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -3213,9 +3213,9 @@

}],

# _FORTIFY_SOURCE isn't really supported by Clang now, see

# http://llvm.org/bugs/show_bug.cgi?id=16821.

- # TODO(glider): once the bug is fixed, disable source fortification

- # under the sanitizer tools only.

- ['os_posix==1 and (OS!="linux" or clang!=1)', {

+ # It seems to work fine with Ubuntu 12 headers though, so use it

+ # in official builds.

+ ['os_posix==1 and (asan!=1 and msan!=1 and tsan!=1 and lsan!=1 and ubsan!=1) and (OS!="linux" or clang!=1 or buildtype=="Official")', {

'target_conditions': [

['chromium_code==1', {

# Non-chromium code is not guaranteed to compile cleanly

« no previous file with comments | « no previous file | no next file » | no next file with comments »