Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: build/android/PRESUBMIT.py

Issue 377373004: [Android] Split DeviceUtils tests and run them in presubmit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/pylib/device/device_utils_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/PRESUBMIT.py
diff --git a/build/android/PRESUBMIT.py b/build/android/PRESUBMIT.py
index 4e25896f27ab95a424636bfc0e15289ab09820bf..4e77b5b037335daf5505bb5cdc144e74773655c9 100644
--- a/build/android/PRESUBMIT.py
+++ b/build/android/PRESUBMIT.py
@@ -50,6 +50,18 @@ def CommonChecks(input_api, output_api):
output.extend(input_api.canned_checks.RunUnitTestsInDirectory(
input_api, output_api, J('buildbot', 'tests')))
+
+ pylib_test_env = dict(input_api.environ)
+ pylib_test_env.update({
+ 'PYTHONPATH': input_api.PresubmitLocalPath(),
+ 'PYTHONDONTWRITEBYTECODE': '1',
+ })
+ output.extend(input_api.canned_checks.RunUnitTests(
frankf 2014/07/10 17:45:09 Why not run all pylib unit tests on the bots? Thes
jbudorick 2014/07/10 18:08:49 I think that should be our goal. Even with that, t
+ input_api,
+ output_api,
+ unit_tests=[
+ J('pylib', 'device', 'device_utils_test.py'),],
+ env=pylib_test_env))
output.extend(_CheckDeletionsOnlyFiles(input_api, output_api))
return output
« no previous file with comments | « no previous file | build/android/pylib/device/device_utils_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698