Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 377353003: Start using proguard.jar directly instead of proguard.sh (Closed)

Created:
6 years, 5 months ago by aurimas (slooooooooow)
Modified:
6 years, 5 months ago
Reviewers:
craigdh, newt (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Start using proguard.jar directly instead of proguard.sh android_tools/sdk/tools/proguard/bin/proguard.sh was removed with SDK tools update. https://gerrit.chromium.org/gerrit/#/c/70802/ updates SDK tools and we want to roll to start using it. BUG=393019 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M build/android/gyp/proguard.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/pylib/instrumentation/test_jar.py View 2 chunks +4 lines, -3 lines 0 comments Download
M build/java.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M build/java_prebuilt.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
aurimas (slooooooooow)
Hey Craig and Newton, Please take a look at this change. This is needed to ...
6 years, 5 months ago (2014-07-10 22:53:28 UTC) #1
newt (away)
lgtm assuming it makes the bots happy
6 years, 5 months ago (2014-07-10 22:56:09 UTC) #2
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 5 months ago (2014-07-10 22:56:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/377353003/1
6 years, 5 months ago (2014-07-10 22:57:45 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 01:49:46 UTC) #5
Message was sent while issue was closed.
Change committed as 282498

Powered by Google App Engine
This is Rietveld 408576698