tools/perf/metrics/v8_object_stats.py - Issue 377343002: Update v8_object_stats to use results.AddValue(...)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/metrics/v8_object_stats.py

Issue 377343002: Update v8_object_stats to use results.AddValue(...) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/metrics/v8_object_stats.py

diff --git a/tools/perf/metrics/v8_object_stats.py b/tools/perf/metrics/v8_object_stats.py

index 92b3daf113342e6ae5b752a6a09457efccce3741..4580b9c8fb06c56b3155b238083812ce62a4d384 100644

--- a/tools/perf/metrics/v8_object_stats.py

+++ b/tools/perf/metrics/v8_object_stats.py

@@ -6,6 +6,8 @@ import json

import logging

from metrics import Metric

+from telemetry.value import scalar

_COUNTER_NAMES = [

'V8.OsMemoryAllocated',

@@ -213,4 +215,6 @@ class V8ObjectStatsMetric(Metric):

assert self._results != None, 'Must call Stop() first'

for counter_name in self._results:

display_name = counter_name.replace('.', '_')

- results.Add(display_name, 'kb', self._results[counter_name] / 1024.0)

+ results.AddValue(scalar.ScalarValue(

+ results.current_page, display_name, 'kb',

+ self._results[counter_name] / 1024.0))

« no previous file with comments | « no previous file | no next file » | no next file with comments »