Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: ash/wm/header_painter.cc

Issue 37733003: Make GetRootWindow() return a Window instead of a RootWindow. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/header_painter.h ('k') | ash/wm/header_painter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/header_painter.cc
diff --git a/ash/wm/header_painter.cc b/ash/wm/header_painter.cc
index 99f851543033c41e6bd719a6c6d3ceba7a3e2d56..3f8f2fe6f3a8abff2ff4c7d7a6bf832803590d64 100644
--- a/ash/wm/header_painter.cc
+++ b/ash/wm/header_painter.cc
@@ -22,7 +22,6 @@
#include "third_party/skia/include/core/SkPath.h"
#include "ui/aura/client/aura_constants.h"
#include "ui/aura/env.h"
-#include "ui/aura/root_window.h"
#include "ui/aura/window.h"
#include "ui/base/hit_test.h"
#include "ui/base/layout.h"
@@ -172,7 +171,7 @@ bool IsSoloWindowHeaderCandidate(aura::Window* window) {
// Returns a list of windows in |root_window|| that potentially could have
// a transparent solo-window header.
-std::vector<Window*> GetWindowsForSoloHeaderUpdate(RootWindow* root_window) {
+std::vector<Window*> GetWindowsForSoloHeaderUpdate(Window* root_window) {
std::vector<Window*> windows;
// Avoid memory allocations for typical window counts.
windows.reserve(16);
@@ -274,7 +273,7 @@ void HeaderPainter::SetSoloWindowHeadersEnabled(bool enabled) {
}
// static
-void HeaderPainter::UpdateSoloWindowHeader(RootWindow* root_window) {
+void HeaderPainter::UpdateSoloWindowHeader(Window* root_window) {
// Use a separate function here so callers outside of HeaderPainter don't need
// to know about "ignorable_window".
UpdateSoloWindowInRoot(root_window, NULL /* ignorable_window */);
@@ -690,15 +689,15 @@ bool HeaderPainter::UseSoloWindowHeader() const {
// Don't use transparent headers for panels, pop-ups, etc.
if (!IsSoloWindowHeaderCandidate(window_))
return false;
- aura::RootWindow* root = window_->GetRootWindow();
+ aura::Window* root = window_->GetRootWindow();
// Don't recompute every time, as it would require many window property
// lookups.
return internal::GetRootWindowSettings(root)->solo_window_header;
}
// static
-bool HeaderPainter::UseSoloWindowHeaderInRoot(RootWindow* root_window,
- Window* ignore_window) {
+bool HeaderPainter::UseSoloWindowHeaderInRoot(Window* root_window,
+ Window* ignore_window) {
int visible_window_count = 0;
std::vector<Window*> windows = GetWindowsForSoloHeaderUpdate(root_window);
for (std::vector<Window*>::const_iterator it = windows.begin();
@@ -722,8 +721,8 @@ bool HeaderPainter::UseSoloWindowHeaderInRoot(RootWindow* root_window,
}
// static
-void HeaderPainter::UpdateSoloWindowInRoot(RootWindow* root,
- Window* ignore_window) {
+void HeaderPainter::UpdateSoloWindowInRoot(Window* root,
+ Window* ignore_window) {
#if defined(OS_WIN)
// Non-Ash Windows doesn't do solo-window counting for transparency effects,
// as the desktop background and window frames are managed by the OS.
« no previous file with comments | « ash/wm/header_painter.h ('k') | ash/wm/header_painter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698