Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 377273003: Add rockot to extensions OWNERS. (Closed)

Created:
6 years, 5 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add rockot to extensions OWNERS. BUG=None NOTRY=True R=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282071

Patch Set 1 #

Patch Set 2 : Oh and docserver too #

Total comments: 1

Patch Set 3 : PROFESSOR CHAOS STRIKES #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -34 lines) Patch
M chrome/browser/extensions/OWNERS View 1 2 1 chunk +8 lines, -7 lines 1 comment Download
M chrome/common/extensions/OWNERS View 1 2 1 chunk +8 lines, -7 lines 0 comments Download
M chrome/common/extensions/docs/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/extensions/OWNERS View 1 2 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/OWNERS View 1 2 1 chunk +8 lines, -7 lines 0 comments Download
M extensions/OWNERS View 1 2 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (1 generated)
Ken Rockot(use gerrit already)
6 years, 5 months ago (2014-07-09 16:31:48 UTC) #1
not at google - send to devlin
https://codereview.chromium.org/377273003/diff/20001/chrome/browser/extensions/OWNERS File chrome/browser/extensions/OWNERS (right): https://codereview.chromium.org/377273003/diff/20001/chrome/browser/extensions/OWNERS#newcode9 chrome/browser/extensions/OWNERS:9: # a unique random sort (sort -R) of these ...
6 years, 5 months ago (2014-07-09 16:32:45 UTC) #2
Ken Rockot(use gerrit already)
On 2014/07/09 16:32:45, kalman wrote: > https://codereview.chromium.org/377273003/diff/20001/chrome/browser/extensions/OWNERS > File chrome/browser/extensions/OWNERS (right): > > https://codereview.chromium.org/377273003/diff/20001/chrome/browser/extensions/OWNERS#newcode9 > ...
6 years, 5 months ago (2014-07-09 16:46:57 UTC) #3
asargent_no_longer_on_chrome
The reason for the random sort is that when it is sorted in alphabetical order, ...
6 years, 5 months ago (2014-07-09 16:51:30 UTC) #4
not at google - send to devlin
Apparently Antony was getting all of the code reviews, the theory was because the script ...
6 years, 5 months ago (2014-07-09 16:51:54 UTC) #5
not at google - send to devlin
On 2014/07/09 16:51:54, kalman wrote: > Apparently Antony was getting all of the code reviews, ...
6 years, 5 months ago (2014-07-09 16:52:55 UTC) #6
not at google - send to devlin
apparently that's an Australian concept: http://en.wikipedia.org/wiki/Donkey_vote
6 years, 5 months ago (2014-07-09 16:54:05 UTC) #7
Ken Rockot(use gerrit already)
OK I've reinstated security measures to guard against accidental donkey-based DDoS attacks
6 years, 5 months ago (2014-07-09 17:02:20 UTC) #8
not at google - send to devlin
lgtm https://codereview.chromium.org/377273003/diff/40001/chrome/browser/extensions/OWNERS File chrome/browser/extensions/OWNERS (right): https://codereview.chromium.org/377273003/diff/40001/chrome/browser/extensions/OWNERS#newcode14 chrome/browser/extensions/OWNERS:14: # extensions/OWNERS we need a script like update_owners.sh ...
6 years, 5 months ago (2014-07-09 17:06:29 UTC) #9
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 5 months ago (2014-07-09 17:08:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/377273003/40001
6 years, 5 months ago (2014-07-09 17:09:31 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 17:11:13 UTC) #12
Message was sent while issue was closed.
Change committed as 282071

Powered by Google App Engine
This is Rietveld 408576698