Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: components/password_manager/core/browser/login_database.cc

Issue 377223003: LoginDatabase::Update should touch all the fields which are synced. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix the test on Mac Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/login_database_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/login_database.cc
diff --git a/components/password_manager/core/browser/login_database.cc b/components/password_manager/core/browser/login_database.cc
index 55cc5eca78b2e59d4c9b4130cc78a5738d7cb001..0863f17303b9ca7f5f825b0bf078a427b864e4ff 100644
--- a/components/password_manager/core/browser/login_database.cc
+++ b/components/password_manager/core/browser/login_database.cc
@@ -362,7 +362,11 @@ PasswordStoreChangeList LoginDatabase::UpdateLogin(const PasswordForm& form) {
"possible_usernames = ?, "
"times_used = ?, "
"submit_element = ?, "
- "date_synced = ? "
+ "date_synced = ?, "
+ "date_created = ?, "
+ "blacklisted_by_user = ?, "
+ "scheme = ?, "
+ "password_type = ? "
"WHERE origin_url = ? AND "
"username_element = ? AND "
"username_value = ? AND "
@@ -378,12 +382,16 @@ PasswordStoreChangeList LoginDatabase::UpdateLogin(const PasswordForm& form) {
s.BindInt(5, form.times_used);
s.BindString16(6, form.submit_element);
s.BindInt64(7, form.date_synced.ToInternalValue());
-
- s.BindString(8, form.origin.spec());
- s.BindString16(9, form.username_element);
- s.BindString16(10, form.username_value);
- s.BindString16(11, form.password_element);
- s.BindString(12, form.signon_realm);
+ s.BindInt64(8, form.date_created.ToTimeT());
+ s.BindInt(9, form.blacklisted_by_user);
+ s.BindInt(10, form.scheme);
+ s.BindInt(11, form.type);
+
+ s.BindString(12, form.origin.spec());
+ s.BindString16(13, form.username_element);
+ s.BindString16(14, form.username_value);
+ s.BindString16(15, form.password_element);
+ s.BindString(16, form.signon_realm);
if (!s.Run())
return PasswordStoreChangeList();
« no previous file with comments | « no previous file | components/password_manager/core/browser/login_database_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698