Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 377223003: LoginDatabase::Update should touch all the fields which are synced. (Closed)

Created:
6 years, 5 months ago by vasilii
Modified:
6 years, 5 months ago
Reviewers:
Garrett Casto
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Project:
chromium
Visibility:
Public.

Description

LoginDatabase::Update should touch all the fields which are synced. BUG=354210 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282340

Patch Set 1 #

Patch Set 2 : Fix the test on Mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -7 lines) Patch
M components/password_manager/core/browser/login_database.cc View 2 chunks +15 lines, -7 lines 0 comments Download
M components/password_manager/core/browser/login_database_unittest.cc View 1 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
vasilii
Hi Garrett, I remember that you had concerns about some PasswordForm members. However, on Linux ...
6 years, 5 months ago (2014-07-09 13:56:11 UTC) #1
Garrett Casto
LGTM Could have sworn that they didn't used to copy the entire form, but I ...
6 years, 5 months ago (2014-07-09 21:50:09 UTC) #2
vasilii
The CQ bit was checked by vasilii@chromium.org
6 years, 5 months ago (2014-07-10 08:01:11 UTC) #3
vasilii
The CQ bit was unchecked by vasilii@chromium.org
6 years, 5 months ago (2014-07-10 08:01:19 UTC) #4
vasilii
They were copied in NativeBackendKWallet but not in NativeBackendGnome. The patch that fixed that was ...
6 years, 5 months ago (2014-07-10 08:04:47 UTC) #5
vasilii
The CQ bit was checked by vasilii@chromium.org
6 years, 5 months ago (2014-07-10 08:04:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/377223003/1
6 years, 5 months ago (2014-07-10 08:07:05 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 11:59:37 UTC) #8
vasilii
The CQ bit was checked by vasilii@chromium.org
6 years, 5 months ago (2014-07-10 12:11:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/377223003/20001
6 years, 5 months ago (2014-07-10 12:11:47 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 14:11:52 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 16:12:15 UTC) #12
Message was sent while issue was closed.
Change committed as 282340

Powered by Google App Engine
This is Rietveld 408576698