Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 377213005: Only compare allocation output in predictable mode. (Closed)

Created:
6 years, 5 months ago by Michael Achenbach
Modified:
6 years, 5 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev, Jakob Kummerow
Project:
v8
Visibility:
Public.

Description

Only compare allocation output in predictable mode. This also adds an assert that makes sure allocations are printed. BUG=391747 LOG=n R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22313

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M tools/testrunner/local/execution.py View 4 chunks +16 lines, -4 lines 0 comments Download
M tools/testrunner/objects/output.py View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
6 years, 5 months ago (2014-07-10 08:19:41 UTC) #1
Igor Sheludko
lgtm
6 years, 5 months ago (2014-07-10 08:57:10 UTC) #2
Michael Achenbach
6 years, 5 months ago (2014-07-10 09:48:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22313 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698