Issue 377173002: [Android] Use Blink UTF8<->UTF16 strings conversion in Gin Java Bridge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 377173002: [Android] Use Blink UTF8<->UTF16 strings conversion in Gin Java Bridge (Closed)

Created:
6 years, 5 months ago by mnaganov (inactive)

Modified:
6 years, 5 months ago

Reviewers:
Torne

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Android] Use Blink UTF8<->UTF16 strings conversion in Gin Java Bridge This patch is mainly for merging into M37. In trunk, we should fix base:: conversion routines instead. Blink UTF conversion routines are considerably faster than the ones from base::, especially on strings that only contain Latin-1 characters, so use them instead. This gives a 9% speed gain on Cordova's "exec" benchmark. BUG=391492 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282017

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -20 lines)			Patch
	M	content/browser/android/java/gin_java_method_invocation_helper.cc	View		3 chunks	+11 lines, -2 lines	0 comments	Download
	M	content/browser/android/java/gin_java_script_to_java_types_coercion.cc	View		8 chunks	+20 lines, -18 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

The CQ bit was checked by mnaganov@chromium.org

6 years, 5 months ago (2014-07-09 10:05:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/377173002/1

6 years, 5 months ago (2014-07-09 10:07:18 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium ...

6 years, 5 months ago (2014-07-09 12:01:05 UTC) #5

Message was sent while issue was closed.

Change committed as 282017

Expand Messages | Collapse Messages