Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 377173002: [Android] Use Blink UTF8<->UTF16 strings conversion in Gin Java Bridge (Closed)

Created:
4 years, 5 months ago by mnaganov (inactive)
Modified:
4 years, 5 months ago
Reviewers:
Torne
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

[Android] Use Blink UTF8<->UTF16 strings conversion in Gin Java Bridge This patch is mainly for merging into M37. In trunk, we should fix base:: conversion routines instead. Blink UTF conversion routines are considerably faster than the ones from base::, especially on strings that only contain Latin-1 characters, so use them instead. This gives a 9% speed gain on Cordova's "exec" benchmark. BUG=391492 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -20 lines) Patch
M content/browser/android/java/gin_java_method_invocation_helper.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M content/browser/android/java/gin_java_script_to_java_types_coercion.cc View 8 chunks +20 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mnaganov (inactive)
4 years, 5 months ago (2014-07-09 09:02:09 UTC) #1
Torne
lgtm
4 years, 5 months ago (2014-07-09 09:47:58 UTC) #2
mnaganov (inactive)
The CQ bit was checked by mnaganov@chromium.org
4 years, 5 months ago (2014-07-09 10:05:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/377173002/1
4 years, 5 months ago (2014-07-09 10:07:18 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium ...
4 years, 5 months ago (2014-07-09 12:01:05 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2014-07-09 13:13:31 UTC) #6
Message was sent while issue was closed.
Change committed as 282017

Powered by Google App Engine
This is Rietveld 408576698