Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 377163002: Use a autorelease pool for the test webkit platform support class (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 5 months ago
Reviewers:
marja
CC:
bruening+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, glider+watch_chromium.org, jam, timurrrr+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Use a autorelease pool for the test webkit platform support class This is required to free the internal resources allocated when creating the stats table BUG=392244 R=marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282029

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M content/test/test_webkit_platform_support.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/valgrind/memcheck/suppressions_mac.txt View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
ptal the mac_valgrind bot is kinda useless :-/
6 years, 5 months ago (2014-07-09 11:56:30 UTC) #1
marja
lgtm
6 years, 5 months ago (2014-07-09 12:00:45 UTC) #2
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 5 months ago (2014-07-09 13:04:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/377163002/1
6 years, 5 months ago (2014-07-09 13:06:56 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 14:05:11 UTC) #5
Message was sent while issue was closed.
Change committed as 282029

Powered by Google App Engine
This is Rietveld 408576698