Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 377153004: Componentize autocomplete_match_type. (Closed)

Created:
6 years, 5 months ago by Jun Mukai
Modified:
6 years, 5 months ago
CC:
chromium-reviews, James Su, browser-components-watch_chromium.org, hashimoto, blundell
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -104 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestion.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/omnibox/autocomplete_controller_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_match.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_result.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_result_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/shortcuts_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/shortcuts_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/shortcuts_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/omnibox/omnibox_field_trial.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/common/autocomplete_match_type.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/common/autocomplete_match_type.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M components/autocomplete.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/autocomplete/autocomplete_match_type.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/autocomplete/autocomplete_match_type.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Jun Mukai
6 years, 5 months ago (2014-07-09 08:32:36 UTC) #1
blundell
lgtm
6 years, 5 months ago (2014-07-09 08:36:36 UTC) #2
Jun Mukai
On 2014/07/09 08:36:36, blundell wrote: > lgtm Thanks for the reply. Let me note that ...
6 years, 5 months ago (2014-07-09 08:43:52 UTC) #3
Peter Kasting
LGTM
6 years, 5 months ago (2014-07-09 18:52:00 UTC) #4
Jun Mukai
On 2014/07/09 18:52:00, Peter Kasting wrote: > LGTM TBR=nyquist for trivial changes on chrome/android/java/... (comment ...
6 years, 5 months ago (2014-07-09 18:57:51 UTC) #5
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 5 months ago (2014-07-09 18:57:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/377153004/1
6 years, 5 months ago (2014-07-09 18:59:02 UTC) #7
nyquist
lgtm
6 years, 5 months ago (2014-07-09 19:00:32 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 01:36:10 UTC) #9
Message was sent while issue was closed. 
Change committed as 282211

Powered by Google App Engine
This is Rietveld 408576698