Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: content/browser/service_worker/service_worker_unregister_job.cc

Issue 377153003: Service Worker: set active worker to REDUNDANT when unregistered (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_unregister_job.cc
diff --git a/content/browser/service_worker/service_worker_unregister_job.cc b/content/browser/service_worker/service_worker_unregister_job.cc
index f60a3b99d3d6cd48880d515b7cde73baf5a77034..9a976ec8da6287ec0f169d1da98dd1b2fcd4bcf6 100644
--- a/content/browser/service_worker/service_worker_unregister_job.cc
+++ b/content/browser/service_worker/service_worker_unregister_job.cc
@@ -68,13 +68,11 @@ void ServiceWorkerUnregisterJob::OnRegistrationFound(
void ServiceWorkerUnregisterJob::DeleteRegistration(
const scoped_refptr<ServiceWorkerRegistration>& registration) {
- // TODO(nhiroki): When we've implemented the installing version, terminate and
- // set it to redundant here as per spec.
-
- if (registration->waiting_version()) {
- registration->waiting_version()->SetStatus(
- ServiceWorkerVersion::REDUNDANT);
- }
+ // TODO: Also doom installing version.
+ if (registration->waiting_version())
+ registration->waiting_version()->Doom();
+ if (registration->active_version())
+ registration->active_version()->Doom();
context_->storage()->DeleteRegistration(
registration->id(),

Powered by Google App Engine
This is Rietveld 408576698