content/browser/service_worker/service_worker_register_job.cc - Issue 377153003: Service Worker: set active worker to REDUNDANT when unregistered

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_register_job.cc

Issue 377153003: Service Worker: set active worker to REDUNDANT when unregistered (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_register_job.cc

diff --git a/content/browser/service_worker/service_worker_register_job.cc b/content/browser/service_worker/service_worker_register_job.cc

index 0903cdb8f15ff818a3622e8e5dfdc70d6fae1236..67793c6004cc4baca63b83b4a2b8af526918e784 100644

--- a/content/browser/service_worker/service_worker_register_job.cc

+++ b/content/browser/service_worker/service_worker_register_job.cc

@@ -390,9 +390,9 @@ void ServiceWorkerRegisterJob::CompleteInternal(

if (status != SERVICE_WORKER_OK) {

if (registration()) {

if (new_version()) {

- new_version()->SetStatus(ServiceWorkerVersion::REDUNDANT);

DisassociateVersionFromDocuments(context_, new_version());

registration()->UnsetVersion(new_version());

+ new_version()->Doom();

}

if (!registration()->active_version()) {

context_->storage()->DeleteRegistration(