sk_malloc_throw/sk_calloc_throw in debug prints size in failure message

sk_malloc_throw/sk_calloc_throw in debug prints size in failure message

Committed: https://skia.googlesource.com/skia/+/61b1436c224482611b864bff354b2664772b1b62

[hal.canary, 2014-07-10 14:58:45]

ptal

[mtklein, 2014-07-10 15:03:40]

https://codereview.chromium.org/377113004/diff/1/src/ports/SkMemory_malloc.cpp
File src/ports/SkMemory_malloc.cpp (right):

https://codereview.chromium.org/377113004/diff/1/src/ports/SkMemory_malloc.cp...
src/ports/SkMemory_malloc.cpp:13: #define SK_DEBUGFAILF(message, ...)           
    \
Can we put this in SkTypes as

#define SK_DEBUGFAILF(fmt, ...) SK_ASSERTF(false, fmt, __VA_ARGS__)

?

https://codereview.chromium.org/377113004/diff/1/src/ports/SkMemory_malloc.cp...
src/ports/SkMemory_malloc.cpp:25: SK_DEBUGFAILF("sk_out_of_memory [0x%lx]",
static_cast<unsigned long>(size));
Let's be explicit this is a byte size, and perhaps not print it as hex?   This
seems easy to misinterpret as a pointer.

SK_DEBUGFAILF("sk_out_of_memory (asked for " SK_SIZE_T_SPECIFIER " bytes)",
size);

?

[hal.canary, 2014-07-10 15:15:11]

https://codereview.chromium.org/377113004/diff/1/src/ports/SkMemory_malloc.cpp
File src/ports/SkMemory_malloc.cpp (right):

https://codereview.chromium.org/377113004/diff/1/src/ports/SkMemory_malloc.cp...
src/ports/SkMemory_malloc.cpp:13: #define SK_DEBUGFAILF(message, ...)           
    \
On 2014/07/10 15:03:40, mtklein wrote:
> Can we put this in SkTypes as
> 
> #define SK_DEBUGFAILF(fmt, ...) SK_ASSERTF(false, fmt, __VA_ARGS__)
> 
> ?

Done.

Mike Reed:  please note that this touches include/ now.

https://codereview.chromium.org/377113004/diff/1/src/ports/SkMemory_malloc.cp...
src/ports/SkMemory_malloc.cpp:25: SK_DEBUGFAILF("sk_out_of_memory [0x%lx]",
static_cast<unsigned long>(size));
On 2014/07/10 15:03:40, mtklein wrote:
> Let's be explicit this is a byte size, and perhaps not print it as hex?   This
> seems easy to misinterpret as a pointer.
> 
> SK_DEBUGFAILF("sk_out_of_memory (asked for " SK_SIZE_T_SPECIFIER " bytes)",
> size);
> 
> ?

Done.

[mtklein, 2014-07-10 15:28:05]

lgtm

[caryclark, 2014-07-10 15:29:56]

lgtm
It's unfortunate that there's no obvious way to add a unit test for this.

[hal.canary, 2014-07-10 15:39:05]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2014-07-10 15:39:47]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/halcanary@google.com/377113004/30001

[commit-bot: I haz the power, 2014-07-10 15:39:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-10 15:39:51]

Presubmit check for 377113004-30001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com')

[reed1, 2014-07-10 15:42:22]

https://codereview.chromium.org/377113004/diff/30001/include/core/SkTypes.h
File include/core/SkTypes.h (right):

https://codereview.chromium.org/377113004/diff/30001/include/core/SkTypes.h#n...
include/core/SkTypes.h:123: #define SK_DEBUGFAILF(fmt, ...)        
SkASSERT((SkDebugf(fmt"\n", __VA_ARGS__), false))
Lets just place this at the one callsite in your impl for now, rather than
introduce another public global macro (at least for now).

[hal.canary, 2014-07-10 15:46:14]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2014-07-10 15:47:17]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/halcanary@google.com/377113004/50001

[commit-bot: I haz the power, 2014-07-10 15:59:44]

Change committed as 61b1436c224482611b864bff354b2664772b1b62