Issue 377113002: Support icu_use_data_file in BUILD.gn for icu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 377113002: Support icu_use_data_file in BUILD.gn for icu. (Closed)

Created:
6 years, 5 months ago by awong

Modified:
6 years, 5 months ago

Reviewers:
brettw

CC:
chromium-reviews, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Support icu_use_data_file in BUILD.gn for icu. Ports over more gyp logic for the icu target. Doesn't correctly account for host toolchains yet, but it's closer. All hail GN. oRZ BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282108

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -17 lines)			Patch
	M	build/secondary/third_party/icu/BUILD.gn	View		3 chunks	+49 lines, -17 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajwong@chromium.org/377113002/1

6 years, 5 months ago (2014-07-09 19:41:25 UTC) #4

Message was sent while issue was closed.

Change committed as 282108

Expand Messages | Collapse Messages