Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 377083003: NaCl: Update revision in DEPS, r13452 -> r13456 (Closed)

Created:
6 years, 5 months ago by Derek Schuff
Modified:
6 years, 5 months ago
Reviewers:
binji
CC:
chromium-reviews, David Yen, native-client-reviews_googlegroups.com, noelallen_use_chromium
Project:
chromium
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r13452 -> r13456 This pulls in the following Native Client changes: r13453: (noelallen) Create GN files for trusted source libraries. r13454: (dyen) Added support for uploading log urls when uploading toolchain packages. r13455: (dyen) Updated some documentation for the package_version files. r13456: (dschuff) Give the minidump_generator_lib gyp rule a shorter name BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build R=binji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282066

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Derek Schuff
ignore all the red bots, LKGR hasn't caught up to the last deps roll yet.
6 years, 5 months ago (2014-07-08 23:52:33 UTC) #1
binji
rubber stamp lgtm
6 years, 5 months ago (2014-07-08 23:55:30 UTC) #2
Derek Schuff
The CQ bit was checked by dschuff@chromium.org
6 years, 5 months ago (2014-07-09 00:28:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dschuff@chromium.org/377083003/1
6 years, 5 months ago (2014-07-09 00:30:19 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 05:08:07 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-09 05:09:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/169148) ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/168550) ios_rel_device ...
6 years, 5 months ago (2014-07-09 05:09:37 UTC) #7
Derek Schuff
The CQ bit was checked by dschuff@chromium.org
6 years, 5 months ago (2014-07-09 16:11:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dschuff@chromium.org/377083003/1
6 years, 5 months ago (2014-07-09 16:12:52 UTC) #9
Derek Schuff
The CQ bit was unchecked by dschuff@chromium.org
6 years, 5 months ago (2014-07-09 16:20:58 UTC) #10
Derek Schuff
6 years, 5 months ago (2014-07-09 16:45:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 manually as r282066 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698