chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java - Issue 377083002: Update menu look and feel on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

Issue 377083002: Update menu look and feel on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased and removed binary pngs Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/values/dimens.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

index 4cfefcf0d77a9275482fcbe68c7299777ee2ef09..a227ef07873ad69287375c247956d6ec7c9d0600 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java

@@ -65,7 +65,7 @@ public class AppMenu implements OnItemClickListener, OnKeyListener {

mHandler = handler;

mItemDividerHeight = itemDividerHeight;

- assert mItemDividerHeight > 0;

+ assert mItemDividerHeight >= 0;

mAdditionalVerticalOffset = res.getDimensionPixelSize(R.dimen.menu_vertical_offset);

mVerticalFadeDistance = res.getDimensionPixelSize(R.dimen.menu_vertical_fade_distance);

@@ -99,6 +99,10 @@ public class AppMenu implements OnItemClickListener, OnKeyListener {

});

mPopup.setWidth(context.getResources().getDimensionPixelSize(R.dimen.menu_width));

+ // Need to explicitly set the background here. Relying on it being set in the style caused

+ // an incorrectly drawn background.

+ mPopup.setBackgroundDrawable(context.getResources().getDrawable(R.drawable.menu_bg));

mCurrentScreenRotation = screenRotation;

mIsByHardwareButton = isByHardwareButton;