Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 377073002: Add support for 64bit atomics (Closed)

Created:
6 years, 5 months ago by bsalomon
Modified:
6 years, 5 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add support for 64bit atomic inc/dec/cas Committed: https://skia.googlesource.com/skia/+/00a8fae0cee239181c9e4fc7775b01b661c72f5e

Patch Set 1 #

Patch Set 2 : _sync impl #

Patch Set 3 : Use function versions on windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -2 lines) Patch
M bench/RefCntBench.cpp View 2 chunks +51 lines, -0 lines 0 comments Download
M include/core/SkThread.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/ports/SkAtomics_sync.h View 1 2 chunks +18 lines, -0 lines 0 comments Download
M src/ports/SkAtomics_win.h View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bsalomon
6 years, 5 months ago (2014-07-08 21:00:31 UTC) #1
mtklein
lgtm
6 years, 5 months ago (2014-07-08 21:50:43 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 5 months ago (2014-07-09 13:22:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/377073002/20001
6 years, 5 months ago (2014-07-09 13:23:08 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Win7-VS2010-x86-Debug-Trybot on tryserver.skia ...
6 years, 5 months ago (2014-07-09 13:44:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-09 13:46:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win7-VS2010-x86-Debug-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Win7-VS2010-x86-Debug-Trybot/builds/719)
6 years, 5 months ago (2014-07-09 13:46:49 UTC) #7
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 5 months ago (2014-07-11 12:47:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/377073002/40001
6 years, 5 months ago (2014-07-11 12:47:39 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 15:42:15 UTC) #10
Message was sent while issue was closed. 
Change committed as 00a8fae0cee239181c9e4fc7775b01b661c72f5e

Powered by Google App Engine
This is Rietveld 408576698