Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 377063002: Revert of Add a probability to Alternate-Protocol support. (Closed)

Created:
6 years, 5 months ago by samuong
Modified:
6 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Add a probability to Alternate-Protocol support. (https://codereview.chromium.org/339663010/) Reason for revert: causes sizes step to fail on linux x64 due to extra static initializers: http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/67438 Original issue's description: > Add a probability to Alternate-Protocol support. Can be enabled either via a field trial or a command line flag. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281777 TBR=rch@chromium.org NOTRY=true NOTREECHECKS=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -420 lines) Patch
M chrome/browser/io_thread.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/io_thread.cc View 8 chunks +3 lines, -39 lines 0 comments Download
M chrome/browser/net/http_server_properties_manager.h View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/net/http_server_properties_manager.cc View 23 chunks +44 lines, -64 lines 0 comments Download
M chrome/browser/net/http_server_properties_manager_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/http/http_network_layer.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/http/http_network_session.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_network_session.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 chunk +6 lines, -9 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 10 chunks +13 lines, -12 lines 0 comments Download
M net/http/http_server_properties.h View 3 chunks +6 lines, -20 lines 0 comments Download
M net/http/http_server_properties.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M net/http/http_server_properties_impl.h View 4 chunks +3 lines, -9 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 8 chunks +13 lines, -27 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 12 chunks +36 lines, -52 lines 0 comments Download
M net/http/http_stream_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory.cc View 3 chunks +31 lines, -53 lines 0 comments Download
M net/http/http_stream_factory_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M net/http/http_stream_factory_impl_job.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 4 chunks +3 lines, -86 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
samuong
Created Revert of Add a probability to Alternate-Protocol support.
6 years, 5 months ago (2014-07-08 19:38:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samuong@chromium.org/377063002/1
6 years, 5 months ago (2014-07-08 19:40:17 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 19:40:17 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-08 19:40:18 UTC) #4
Cait (Slow)
lgtm
6 years, 5 months ago (2014-07-08 19:45:32 UTC) #5
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-08 19:45:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samuong@chromium.org/377063002/1
6 years, 5 months ago (2014-07-08 19:46:47 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 19:49:52 UTC) #8
Message was sent while issue was closed.
Change committed as 281796

Powered by Google App Engine
This is Rietveld 408576698