chrome/browser/extensions/extension_browser_actions_api.h - Issue 377036: Fix memory leak in AsyncExtensionFunction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_browser_actions_api.h

Issue 377036: Fix memory leak in AsyncExtensionFunction. (Closed)

Patch Set: feedback Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_browser_actions_api.h

diff --git a/chrome/browser/extensions/extension_browser_actions_api.h b/chrome/browser/extensions/extension_browser_actions_api.h

index fceab484d4d99978e4922dfba075555c99f886b7..7853d0925360d6c0dbb76bb344a0aa345e2a3f36 100644

--- a/chrome/browser/extensions/extension_browser_actions_api.h

+++ b/chrome/browser/extensions/extension_browser_actions_api.h

@@ -20,7 +20,7 @@ class BrowserActionFunction : public SyncExtensionFunction {

// All the browser action APIs take a single argument called details that is

// a dictionary.

- DictionaryValue* details_;

+ const DictionaryValue* details_;

// The tab id the browser action function should apply to, if any, or

// kDefaultTabId if none was specified.