chrome/browser/extensions/extension_browser_actions_api.cc - Issue 377036: Fix memory leak in AsyncExtensionFunction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_browser_actions_api.cc

Issue 377036: Fix memory leak in AsyncExtensionFunction. (Closed)

Patch Set: feedback Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_browser_actions_api.cc

diff --git a/chrome/browser/extensions/extension_browser_actions_api.cc b/chrome/browser/extensions/extension_browser_actions_api.cc

index bc83fd02e1ad3081a97e2e5119facdb3b6b507a1..012f582ca0c39a6270868557338f92d8735bb400 100644

--- a/chrome/browser/extensions/extension_browser_actions_api.cc

+++ b/chrome/browser/extensions/extension_browser_actions_api.cc

@@ -19,7 +19,7 @@ const char kIconIndexOutOfBounds[] =

bool BrowserActionFunction::RunImpl() {

EXTENSION_FUNCTION_VALIDATE(args_->IsType(Value::TYPE_DICTIONARY));

- details_ = static_cast<DictionaryValue*>(args_);

+ details_ = args_as_dictionary();

if (details_->HasKey(L"tabId"))

EXTENSION_FUNCTION_VALIDATE(details_->GetInteger(L"tabId", &tab_id_));