Check for an active network connection when network adapter status changes....

Check for an active network connection when network adapter status changes.

BUG=19784
TEST=On a system with two network adapters, ensure one has an active internet
connection, and the other does not.  Disconnect the active one, and check that
in notifier::NetworkStatusDetectorTaskMT::OnNetworkAliveDone() the call to
network_alive->alive() returns false.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31623

[tim (not reviewing), 2009-11-10 23:43:10]

http://codereview.chromium.org/377019/diff/1/2
File chrome/browser/sync/notifier/base/win/async_network_alive_win32.cc (right):

http://codereview.chromium.org/377019/diff/1/2#newcode225
Line 225: talk_base::Socket* socket = physical.CreateSocket(SOCK_STREAM);
nit- i'd do 
scoped_ptr<talk_base::Socket> socket(physical.CreateSocket);

and then not worry about having to cleanup below.

http://codereview.chromium.org/377019/diff/1/2#newcode226
Line 226: if (socket->Connect(talk_base::SocketAddress("www.google.com", 80))) {
I dug around a bit and it looks like using talk.google.com:5222 (default xmpp
port) would be a more accurate test.

[tim (not reviewing), 2009-11-10 23:43:29]

http://codereview.chromium.org/377019/diff/1/2
File chrome/browser/sync/notifier/base/win/async_network_alive_win32.cc
(right):

http://codereview.chromium.org/377019/diff/1/2#newcode225
Line 225: talk_base::Socket* socket =
physical.CreateSocket(SOCK_STREAM);
nit- i'd do
scoped_ptr<talk_base::Socket> socket(physical.CreateSocket);

and then not worry about having to cleanup below.

http://codereview.chromium.org/377019/diff/1/2#newcode226
Line 226: if (socket->Connect(talk_base::SocketAddress("www.google.com",
80))) {
I dug around a bit and it looks like using talk.google.com:5222 (default
xmpp port) would be a more accurate test.

http://codereview.chromium.org/377019

[Zachary Kuznia, 2009-11-10 23:51:55]

http://codereview.chromium.org/377019/diff/1/2
File chrome/browser/sync/notifier/base/win/async_network_alive_win32.cc (right):

http://codereview.chromium.org/377019/diff/1/2#newcode225
Line 225: talk_base::Socket* socket = physical.CreateSocket(SOCK_STREAM);
On 2009/11/10 23:43:11, timsteele wrote:
> nit- i'd do 
> scoped_ptr<talk_base::Socket> socket(physical.CreateSocket);
> 
> and then not worry about having to cleanup below.

Done.

http://codereview.chromium.org/377019/diff/1/2#newcode226
Line 226: if (socket->Connect(talk_base::SocketAddress("www.google.com", 80))) {
On 2009/11/10 23:43:11, timsteele wrote:
> I dug around a bit and it looks like using talk.google.com:5222 (default xmpp
> port) would be a more accurate test.

Done.

[Zachary Kuznia, 2009-11-10 23:52:12]

http://codereview.chromium.org/377019/diff/1/2
File chrome/browser/sync/notifier/base/win/async_network_alive_win32.cc
(right):

http://codereview.chromium.org/377019/diff/1/2#newcode225
Line 225: talk_base::Socket* socket =
physical.CreateSocket(SOCK_STREAM);
On 2009/11/10 23:43:11, timsteele wrote:
> nit- i'd do
> scoped_ptr<talk_base::Socket> socket(physical.CreateSocket);

> and then not worry about having to cleanup below.

Done.

http://codereview.chromium.org/377019/diff/1/2#newcode226
Line 226: if (socket->Connect(talk_base::SocketAddress("www.google.com",
80))) {
On 2009/11/10 23:43:11, timsteele wrote:
> I dug around a bit and it looks like using talk.google.com:5222
(default xmpp
> port) would be a more accurate test.

Done.

http://codereview.chromium.org/377019

[tim (not reviewing), 2009-11-11 00:43:13]

LGTM

[tim (not reviewing), 2009-11-11 00:43:30]

LGTM

http://codereview.chromium.org/377019