content/browser/renderer_host/render_widget_host_view_android.h - Issue 377013002: android: Use UIResource for overscroll glow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 377013002: android: Use UIResource for overscroll glow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments. moved resource loading to its own class. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_android.h

diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h

index bfdaeac898a4944799d6c2353742ef0cfa9b6f4b..514c7b58dffc2e60b3749a6b13eee0a4e1372d41 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.h

+++ b/content/browser/renderer_host/render_widget_host_view_android.h

@@ -336,7 +336,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid

const bool overscroll_effect_enabled_;

// Used to render overscroll overlays.

- // Note: |overscroll_effect_| will never be NULL, even if it's never enabled.

scoped_ptr<OverscrollGlow> overscroll_effect_;

// Provides gesture synthesis given a stream of touch events (derived from