android: Use UIResource for overscroll glow

content/browser/android/system_ui_resource_manager_impl.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_ANDROID_SYSTEM_UI_RESOURCE_MANAGER_IMPL_H_
+#define CONTENT_BROWSER_ANDROID_SYSTEM_UI_RESOURCE_MANAGER_IMPL_H_
+
+#include "base/basictypes.h"
+#include "base/containers/scoped_ptr_hash_map.h"
+#include "base/memory/weak_ptr.h"
+#include "base/observer_list.h"

[jdduke (slow), 2014/07/23 18:17:45]

Is observer_list.h used in the header? Could it be pulled in through the .cc?

[powei, 2014/07/23 21:56:09]

Done.

+#include "content/browser/android/system_ui_resource.h"

[jdduke (slow), 2014/07/23 18:17:45]

Do we need the include? Is the forward declaration of SystemUIResource below not
sufficient?

[powei, 2014/07/23 21:56:09]

Done.

+#include "content/common/content_export.h"
+#include "ui/base/android/system_ui_resource_manager.h"
+
+class SkBitmap;
+
+namespace cc {
+class UIResourceBitmap;
+}
+
+namespace content {
+
+class SystemUIResource;
+
+class CONTENT_EXPORT SystemUIResourceManagerImpl
+    : public ui::SystemUIResourceManager {
+ public:
+  SystemUIResourceManagerImpl(UIResourceProvider* ui_resource_provider);
+  ~SystemUIResourceManagerImpl();
+
+  virtual void Subscribe(ui::SystemUIResourceManager::Type type,
+                         ui::SystemUIResourceLayer* layer) OVERRIDE;
+  virtual void Unsubscribe(ui::SystemUIResourceManager::Type type,
+                           ui::SystemUIResourceLayer* layer) OVERRIDE;
+  void RefreshResources();

[jdduke (slow), 2014/07/23 18:17:45]

A comment about what |RefreshResources()| accomplishes and when to call it would
be helpful.

[powei, 2014/07/23 21:56:09]

Done.

+
+ private:
+  friend class TestSystemUIResourceManagerImpl;
+  class Entry;
+
+  // Start loading the resource bitmap.  virtual for testing.
+  virtual void BuildResource(ui::SystemUIResourceManager::Type type);
+
+  Entry* GetEntry(ui::SystemUIResourceManager::Type type);
+  static void LoadBitmap(ui::SystemUIResourceManager::Type,
+                         SkBitmap* bitmap_holder);
+  void OnFinishedLoadBitmap(ui::SystemUIResourceManager::Type,
+                            SkBitmap* bitmap_holder);
+
+  typedef base::ScopedPtrHashMap<int, Entry> SystemUIResourceMap;
+  SystemUIResourceMap resource_map_;
+  UIResourceProvider* ui_resource_provider_;
+
+  base::WeakPtrFactory<SystemUIResourceManagerImpl> weak_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(SystemUIResourceManagerImpl);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_ANDROID_SYSTEM_UI_RESOURCE_MANAGER_IMPL_H_