Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1213)

Unified Diff: src/objects.h

Issue 376973002: [Arm]: Optimize ConstantPoolBuilder::Populate code by minimizing calls to OffsetOfElementAt (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm/assembler-arm.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index a5a312bd9cb16ba060e756404bbe103ce7de3f7a..2b747c93ed8882ae7618457c681acd50ff7c15e9 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -3125,7 +3125,8 @@ class ConstantPoolArray: public HeapObject {
enum LayoutSection {
SMALL_SECTION = 0,
- EXTENDED_SECTION
+ EXTENDED_SECTION,
+ NUMBER_OF_LAYOUT_SECTIONS
};
class NumberOfEntries BASE_EMBEDDED {
@@ -3204,6 +3205,7 @@ class ConstantPoolArray: public HeapObject {
// Returns the type of the entry at the given index.
inline Type get_type(int index);
+ inline bool offset_is_type(int offset, Type type);
// Setter and getter for pool elements.
inline Address get_code_ptr_entry(int index);
@@ -3218,6 +3220,13 @@ class ConstantPoolArray: public HeapObject {
inline void set(int index, double value);
inline void set(int index, int32_t value);
+ // Setters which take a raw offset rather than an index (for code generation).
+ inline void set_at_offset(int offset, int32_t value);
+ inline void set_at_offset(int offset, int64_t value);
+ inline void set_at_offset(int offset, double value);
+ inline void set_at_offset(int offset, Address value);
+ inline void set_at_offset(int offset, Object* value);
+
// Setter and getter for weak objects state
inline void set_weak_object_state(WeakObjectState state);
inline WeakObjectState get_weak_object_state();
« no previous file with comments | « src/arm/assembler-arm.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698