Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 376973002: [Arm]: Optimize ConstantPoolBuilder::Populate code by minimizing calls to OffsetOfElementAt (Closed)

Created:
6 years, 5 months ago by rmcilroy
Modified:
6 years, 5 months ago
Reviewers:
ulan
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[Arm]: Optimize ConstantPoolBuilder::Populate code by minimizing calls to OffsetOfElementAt Calling OffsetOfElementAt becomes expensive when compiling functions with many constant pool entries. This was causing a regression in MandreelLatency due to the time spent populating the constant pool array for large compiled functions. This change avoids calling OffsetOfElementAt for each entry, and instead keeps track of the current offsets in ConstantPoolBuilder::Populate. This gives the following improvements on a Nexus 5: Inline CP | OOL CP (before CL) | OOL CP (after CL) Mandreel: 4305 | 3961 | 4120 MandreelLatency: 2298 | 1198 | 1994 Octane Score: 5197 | 4982 | 5152 R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22293

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -22 lines) Patch
M src/arm/assembler-arm.cc View 4 chunks +25 lines, -21 lines 0 comments Download
M src/objects.h View 3 chunks +10 lines, -1 line 0 comments Download
M src/objects-inl.h View 2 chunks +46 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmcilroy
PTAL Ulan, thanks.
6 years, 5 months ago (2014-07-08 15:43:06 UTC) #1
ulan
lgtm
6 years, 5 months ago (2014-07-09 08:41:54 UTC) #2
rmcilroy
6 years, 5 months ago (2014-07-09 09:08:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22293 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698