Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Side by Side Diff: include/effects/SkXfermodeImageFilter.h

Issue 376953003: Clean up SkImageFilter constructors. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Fixed 100-col issues Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « include/effects/SkTileImageFilter.h ('k') | src/core/SkImageFilter.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2013 The Android Open Source Project 2 * Copyright 2013 The Android Open Source Project
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkXfermodeImageFilter_DEFINED 8 #ifndef SkXfermodeImageFilter_DEFINED
9 #define SkXfermodeImageFilter_DEFINED 9 #define SkXfermodeImageFilter_DEFINED
10 10
11 #include "SkImageFilter.h" 11 #include "SkImageFilter.h"
12 12
13 class SkBitmap; 13 class SkBitmap;
14 class SkXfermode; 14 class SkXfermode;
15 15
16 class SK_API SkXfermodeImageFilter : public SkImageFilter { 16 class SK_API SkXfermodeImageFilter : public SkImageFilter {
17 /** 17 /**
18 * This filter takes an xfermode, and uses it to composite the foreground 18 * This filter takes an xfermode, and uses it to composite the foreground
19 * over the background. If foreground or background is NULL, the input 19 * over the background. If foreground or background is NULL, the input
20 * bitmap (src) is used instead. 20 * bitmap (src) is used instead.
21 */ 21 */
22 22
23 public: 23 public:
24 virtual ~SkXfermodeImageFilter(); 24 virtual ~SkXfermodeImageFilter();
25 25
26 static SkXfermodeImageFilter* Create(SkXfermode* mode, SkImageFilter* backgr ound, 26 static SkXfermodeImageFilter* Create(SkXfermode* mode, SkImageFilter* backgr ound,
27 SkImageFilter* foreground = NULL, 27 SkImageFilter* foreground = NULL,
28 const CropRect* cropRect = NULL) { 28 const CropRect* cropRect = NULL) {
29 return SkNEW_ARGS(SkXfermodeImageFilter, (mode, background, foreground, cropRect)); 29 SkImageFilter* inputs[2] = { background, foreground };
30 return SkNEW_ARGS(SkXfermodeImageFilter, (mode, inputs, cropRect));
30 } 31 }
31 32
32 SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkXfermodeImageFilter) 33 SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkXfermodeImageFilter)
33 34
34 virtual bool onFilterImage(Proxy* proxy, 35 virtual bool onFilterImage(Proxy* proxy,
35 const SkBitmap& src, 36 const SkBitmap& src,
36 const Context& ctx, 37 const Context& ctx,
37 SkBitmap* dst, 38 SkBitmap* dst,
38 SkIPoint* offset) const SK_OVERRIDE; 39 SkIPoint* offset) const SK_OVERRIDE;
39 #if SK_SUPPORT_GPU 40 #if SK_SUPPORT_GPU
40 virtual bool canFilterImageGPU() const SK_OVERRIDE; 41 virtual bool canFilterImageGPU() const SK_OVERRIDE;
41 virtual bool filterImageGPU(Proxy* proxy, const SkBitmap& src, const Context & ctx, 42 virtual bool filterImageGPU(Proxy* proxy, const SkBitmap& src, const Context & ctx,
42 SkBitmap* result, SkIPoint* offset) const SK_OVE RRIDE; 43 SkBitmap* result, SkIPoint* offset) const SK_OVE RRIDE;
43 #endif 44 #endif
44 45
45 protected: 46 protected:
46 SkXfermodeImageFilter(SkXfermode* mode, SkImageFilter* background, 47 SkXfermodeImageFilter(SkXfermode* mode, SkImageFilter* inputs[2],
47 SkImageFilter* foreground, const CropRect* cropRect); 48 const CropRect* cropRect);
48 explicit SkXfermodeImageFilter(SkReadBuffer& buffer); 49 explicit SkXfermodeImageFilter(SkReadBuffer& buffer);
49 virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE; 50 virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE;
50 51
51 private: 52 private:
52 SkXfermode* fMode; 53 SkXfermode* fMode;
53 typedef SkImageFilter INHERITED; 54 typedef SkImageFilter INHERITED;
54 }; 55 };
55 56
56 #endif 57 #endif
OLDNEW
« no previous file with comments | « include/effects/SkTileImageFilter.h ('k') | src/core/SkImageFilter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698