Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Side by Side Diff: include/effects/SkMergeImageFilter.h

Issue 376953003: Clean up SkImageFilter constructors. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Fixed 100-col issues Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « include/effects/SkMatrixImageFilter.h ('k') | include/effects/SkMorphologyImageFilter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The Android Open Source Project 2 * Copyright 2012 The Android Open Source Project
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkMergeImageFilter_DEFINED 8 #ifndef SkMergeImageFilter_DEFINED
9 #define SkMergeImageFilter_DEFINED 9 #define SkMergeImageFilter_DEFINED
10 10
11 #include "SkImageFilter.h" 11 #include "SkImageFilter.h"
12 12
13 #include "SkXfermode.h" 13 #include "SkXfermode.h"
14 14
15 class SK_API SkMergeImageFilter : public SkImageFilter { 15 class SK_API SkMergeImageFilter : public SkImageFilter {
16 public: 16 public:
17 virtual ~SkMergeImageFilter(); 17 virtual ~SkMergeImageFilter();
18 18
19 static SkMergeImageFilter* Create(SkImageFilter* first, SkImageFilter* secon d, 19 static SkMergeImageFilter* Create(SkImageFilter* first, SkImageFilter* secon d,
20 SkXfermode::Mode mode = SkXfermode::kSrcOv er_Mode, 20 SkXfermode::Mode mode = SkXfermode::kSrcOv er_Mode,
21 const CropRect* cropRect = NULL) { 21 const CropRect* cropRect = NULL) {
22 return SkNEW_ARGS(SkMergeImageFilter, (first, second, mode, cropRect)); 22 SkImageFilter* inputs[2] = { first, second };
23 SkXfermode::Mode modes[2] = { mode, mode };
24 return SkNEW_ARGS(SkMergeImageFilter, (inputs, 2, modes, cropRect));
23 } 25 }
24 static SkMergeImageFilter* Create(SkImageFilter* filters[], int count, 26 static SkMergeImageFilter* Create(SkImageFilter* filters[], int count,
25 const SkXfermode::Mode modes[] = NULL, 27 const SkXfermode::Mode modes[] = NULL,
26 const CropRect* cropRect = NULL) { 28 const CropRect* cropRect = NULL) {
27 return SkNEW_ARGS(SkMergeImageFilter, (filters, count, modes, cropRect)) ; 29 return SkNEW_ARGS(SkMergeImageFilter, (filters, count, modes, cropRect)) ;
28 } 30 }
29 31
30 SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkMergeImageFilter) 32 SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkMergeImageFilter)
31 33
32 protected: 34 protected:
33 SkMergeImageFilter(SkImageFilter* first, SkImageFilter* second,
34 SkXfermode::Mode = SkXfermode::kSrcOver_Mode,
35 const CropRect* cropRect = NULL);
36 SkMergeImageFilter(SkImageFilter* filters[], int count, 35 SkMergeImageFilter(SkImageFilter* filters[], int count,
37 const SkXfermode::Mode modes[] = NULL, 36 const SkXfermode::Mode modes[],
38 const CropRect* cropRect = NULL); 37 const CropRect* cropRect);
39 explicit SkMergeImageFilter(SkReadBuffer& buffer); 38 explicit SkMergeImageFilter(SkReadBuffer& buffer);
40 virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE; 39 virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE;
41 40
42 virtual bool onFilterImage(Proxy*, const SkBitmap& src, const Context&, 41 virtual bool onFilterImage(Proxy*, const SkBitmap& src, const Context&,
43 SkBitmap* result, SkIPoint* loc) const SK_OVERRID E; 42 SkBitmap* result, SkIPoint* loc) const SK_OVERRID E;
44 43
45 private: 44 private:
46 uint8_t* fModes; // SkXfermode::Mode 45 uint8_t* fModes; // SkXfermode::Mode
47 46
48 // private storage, to avoid dynamically allocating storage for our copy 47 // private storage, to avoid dynamically allocating storage for our copy
49 // of the modes (unless the count is so large we can't fit). 48 // of the modes (unless the count is so large we can't fit).
50 intptr_t fStorage[16]; 49 intptr_t fStorage[16];
51 50
52 void initAllocModes(); 51 void initAllocModes();
53 void initModes(const SkXfermode::Mode []); 52 void initModes(const SkXfermode::Mode []);
54 53
55 typedef SkImageFilter INHERITED; 54 typedef SkImageFilter INHERITED;
56 }; 55 };
57 56
58 #endif 57 #endif
OLDNEW
« no previous file with comments | « include/effects/SkMatrixImageFilter.h ('k') | include/effects/SkMorphologyImageFilter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698