Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: include/effects/SkDisplacementMapEffect.h

Issue 376953003: Clean up SkImageFilter constructors. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Fixed 100-col issues Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « include/effects/SkComposeImageFilter.h ('k') | include/effects/SkLightingImageFilter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkDisplacementMapEffect_DEFINED 8 #ifndef SkDisplacementMapEffect_DEFINED
9 #define SkDisplacementMapEffect_DEFINED 9 #define SkDisplacementMapEffect_DEFINED
10 10
(...skipping 10 matching lines...) Expand all
21 kA_ChannelSelectorType 21 kA_ChannelSelectorType
22 }; 22 };
23 23
24 ~SkDisplacementMapEffect(); 24 ~SkDisplacementMapEffect();
25 25
26 static SkDisplacementMapEffect* Create(ChannelSelectorType xChannelSelector, 26 static SkDisplacementMapEffect* Create(ChannelSelectorType xChannelSelector,
27 ChannelSelectorType yChannelSelector, 27 ChannelSelectorType yChannelSelector,
28 SkScalar scale, SkImageFilter* displa cement, 28 SkScalar scale, SkImageFilter* displa cement,
29 SkImageFilter* color = NULL, 29 SkImageFilter* color = NULL,
30 const CropRect* cropRect = NULL) { 30 const CropRect* cropRect = NULL) {
31 SkImageFilter* inputs[2] = { displacement, color };
31 return SkNEW_ARGS(SkDisplacementMapEffect, (xChannelSelector, yChannelSe lector, scale, 32 return SkNEW_ARGS(SkDisplacementMapEffect, (xChannelSelector, yChannelSe lector, scale,
32 displacement, color, cropRec t)); 33 inputs, cropRect));
33 } 34 }
34 35
35 SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkDisplacementMapEffect) 36 SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkDisplacementMapEffect)
36 37
37 virtual bool onFilterImage(Proxy* proxy, 38 virtual bool onFilterImage(Proxy* proxy,
38 const SkBitmap& src, 39 const SkBitmap& src,
39 const Context& ctx, 40 const Context& ctx,
40 SkBitmap* dst, 41 SkBitmap* dst,
41 SkIPoint* offset) const SK_OVERRIDE; 42 SkIPoint* offset) const SK_OVERRIDE;
42 virtual void computeFastBounds(const SkRect& src, SkRect* dst) const SK_OVER RIDE; 43 virtual void computeFastBounds(const SkRect& src, SkRect* dst) const SK_OVER RIDE;
43 44
44 virtual bool onFilterBounds(const SkIRect& src, const SkMatrix&, 45 virtual bool onFilterBounds(const SkIRect& src, const SkMatrix&,
45 SkIRect* dst) const SK_OVERRIDE; 46 SkIRect* dst) const SK_OVERRIDE;
46 47
47 #if SK_SUPPORT_GPU 48 #if SK_SUPPORT_GPU
48 virtual bool canFilterImageGPU() const SK_OVERRIDE { return true; } 49 virtual bool canFilterImageGPU() const SK_OVERRIDE { return true; }
49 virtual bool filterImageGPU(Proxy* proxy, const SkBitmap& src, const Context & ctx, 50 virtual bool filterImageGPU(Proxy* proxy, const SkBitmap& src, const Context & ctx,
50 SkBitmap* result, SkIPoint* offset) const SK_OVE RRIDE; 51 SkBitmap* result, SkIPoint* offset) const SK_OVE RRIDE;
51 #endif 52 #endif
52 53
53 protected: 54 protected:
54 SkDisplacementMapEffect(ChannelSelectorType xChannelSelector, 55 SkDisplacementMapEffect(ChannelSelectorType xChannelSelector,
55 ChannelSelectorType yChannelSelector, 56 ChannelSelectorType yChannelSelector,
56 SkScalar scale, SkImageFilter* displacement, 57 SkScalar scale, SkImageFilter* inputs[2],
57 SkImageFilter* color = NULL, 58 const CropRect* cropRect);
58 const CropRect* cropRect = NULL);
59 explicit SkDisplacementMapEffect(SkReadBuffer& buffer); 59 explicit SkDisplacementMapEffect(SkReadBuffer& buffer);
60 virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE; 60 virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE;
61 61
62 private: 62 private:
63 ChannelSelectorType fXChannelSelector; 63 ChannelSelectorType fXChannelSelector;
64 ChannelSelectorType fYChannelSelector; 64 ChannelSelectorType fYChannelSelector;
65 SkScalar fScale; 65 SkScalar fScale;
66 typedef SkImageFilter INHERITED; 66 typedef SkImageFilter INHERITED;
67 const SkImageFilter* getDisplacementInput() const { return getInput(0); } 67 const SkImageFilter* getDisplacementInput() const { return getInput(0); }
68 const SkImageFilter* getColorInput() const { return getInput(1); } 68 const SkImageFilter* getColorInput() const { return getInput(1); }
69 }; 69 };
70 70
71 #endif 71 #endif
OLDNEW
« no previous file with comments | « include/effects/SkComposeImageFilter.h ('k') | include/effects/SkLightingImageFilter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698