Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: include/core/SkImageFilter.h

Issue 376953003: Clean up SkImageFilter constructors. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Fixed 100-col issues Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gm/imagefiltersgraph.cpp ('k') | include/effects/SkAlphaThresholdFilter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2011 Google Inc. 2 * Copyright 2011 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkImageFilter_DEFINED 8 #ifndef SkImageFilter_DEFINED
9 #define SkImageFilter_DEFINED 9 #define SkImageFilter_DEFINED
10 10
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 /** 194 /**
195 * Returns the currently-set external cache, or NULL if none is set. 195 * Returns the currently-set external cache, or NULL if none is set.
196 */ 196 */
197 static Cache* GetExternalCache(); 197 static Cache* GetExternalCache();
198 198
199 SK_DEFINE_FLATTENABLE_TYPE(SkImageFilter) 199 SK_DEFINE_FLATTENABLE_TYPE(SkImageFilter)
200 200
201 protected: 201 protected:
202 SkImageFilter(int inputCount, SkImageFilter** inputs, const CropRect* cropRe ct = NULL); 202 SkImageFilter(int inputCount, SkImageFilter** inputs, const CropRect* cropRe ct = NULL);
203 203
204 // Convenience constructor for 1-input filters.
205 explicit SkImageFilter(SkImageFilter* input, const CropRect* cropRect = NULL );
206
207 // Convenience constructor for 2-input filters.
208 SkImageFilter(SkImageFilter* input1, SkImageFilter* input2, const CropRect* cropRect = NULL);
209
210 virtual ~SkImageFilter(); 204 virtual ~SkImageFilter();
211 205
212 /** 206 /**
213 * Constructs a new SkImageFilter read from an SkReadBuffer object. 207 * Constructs a new SkImageFilter read from an SkReadBuffer object.
214 * 208 *
215 * @param inputCount The exact number of inputs expected for this SkImag eFilter object. 209 * @param inputCount The exact number of inputs expected for this SkImag eFilter object.
216 * -1 can be used if the filter accepts any number of inputs. 210 * -1 can be used if the filter accepts any number of inputs.
217 * @param rb SkReadBuffer object from which the SkImageFilter is read. 211 * @param rb SkReadBuffer object from which the SkImageFilter is read.
218 */ 212 */
219 explicit SkImageFilter(int inputCount, SkReadBuffer& rb); 213 explicit SkImageFilter(int inputCount, SkReadBuffer& rb);
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
288 const SkIRect& bounds) const; 282 const SkIRect& bounds) const;
289 283
290 private: 284 private:
291 typedef SkFlattenable INHERITED; 285 typedef SkFlattenable INHERITED;
292 int fInputCount; 286 int fInputCount;
293 SkImageFilter** fInputs; 287 SkImageFilter** fInputs;
294 CropRect fCropRect; 288 CropRect fCropRect;
295 }; 289 };
296 290
297 #endif 291 #endif
OLDNEW
« no previous file with comments | « gm/imagefiltersgraph.cpp ('k') | include/effects/SkAlphaThresholdFilter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698