Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 37693004: Remove float/double conversions from SkMatrix44's map2_pf (Closed)

Created:
7 years, 2 months ago by enne (OOO)
Modified:
7 years, 1 month ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove float/double conversions from SkMatrix44's map2_pf BUG=chromium:303811 Committed: http://code.google.com/p/skia/source/detail?r=11986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M src/utils/SkMatrix44.cpp View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
enne (OOO)
What do you think about removing the doubles here? I am wondering if this makes ...
7 years, 2 months ago (2013-10-23 22:17:27 UTC) #1
tomhudson
Test like crazy? It feels a bit odd, since I think all the consumers of ...
7 years, 2 months ago (2013-10-24 07:20:33 UTC) #2
reed1
I think the fastest would be to avoid as many conversions as possible. If the ...
7 years, 2 months ago (2013-10-24 16:06:49 UTC) #3
enne (OOO)
The bench target appears to not call map2_pf. Are there other benchmarks I should be ...
7 years, 2 months ago (2013-10-24 18:44:25 UTC) #4
enne (OOO)
Are there other Skia tests I should run other than bench?
7 years, 1 month ago (2013-10-28 17:12:35 UTC) #5
enne (OOO)
Running locally, this looks like a clear 25% win for the regressed test: https://docs.google.com/a/chromium.org/spreadsheet/ccc?key=0AklwB21ZzpmDdEQ2andBZVk5YWZLRUFER2tvM1duZVE#gid=0 Given ...
7 years, 1 month ago (2013-10-28 20:01:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/enne@chromium.org/37693004/1
7 years, 1 month ago (2013-10-28 20:03:23 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-10-28 20:20:57 UTC) #8
Message was sent while issue was closed.
Change committed as 11986

Powered by Google App Engine
This is Rietveld 408576698