Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 376893002: On tap in editable node with some text complete text gets selected instead of showing insertion han…

Created:
6 years, 5 months ago by divya.bansal
Modified:
6 years, 3 months ago
Reviewers:
esprehn, yosin_UTC9, ojan
CC:
blink-reviews, lgombos, yoichio, donnd, Rick Byers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

On tap in editable node with some text complete text gets selected instead of showing insertion handler On Longpress, m_start is set to Zero as wordside is set to LeftWordIfOnBoundary. So the word left to this is getting selected. To show paste popup instead of selecting,the word side to RightWordIfOnBoundary is changed. So that m_start is set to end of the word, and selection does not happen. BUG=392101

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/editing/VisibleSelection.cpp View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
divya.bansal
PTAL
6 years, 5 months ago (2014-07-08 09:19:18 UTC) #1
divya.bansal
PTAL
6 years, 5 months ago (2014-07-25 16:51:21 UTC) #2
esprehn
Tests? Have a screenshot of what you're changing here...
6 years, 4 months ago (2014-08-19 02:10:40 UTC) #3
yosin_UTC9
Please add layout test for your change. Thanks in advance. https://codereview.chromium.org/376893002/diff/1/Source/core/editing/VisibleSelection.cpp File Source/core/editing/VisibleSelection.cpp (right): https://codereview.chromium.org/376893002/diff/1/Source/core/editing/VisibleSelection.cpp#newcode364 ...
6 years, 4 months ago (2014-08-25 01:10:26 UTC) #4
use-l.gombos-samsung.com
6 years, 3 months ago (2014-09-23 19:31:21 UTC) #5
yosin_UTC9
6 years, 3 months ago (2014-09-25 02:16:03 UTC) #6
Let's implement touch related thing in EventHandler, rather than editing
component, which is independent from input and output.

For this case, it is in |selectClosestWordFromHitTestResult()|. 

We may want to have touch version of |selectClosestWordFromHitTestResult()| and
it should be smarter about @media (pointer:coarse) with considering zoom.

There is another patch for selecting word by tap: http://crrev.com/585963002

Powered by Google App Engine
This is Rietveld 408576698