Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 376873004: [DevTools] Allow touch emulation on devices with native touch. (Closed)

Created:
6 years, 5 months ago by dgozman
Modified:
6 years, 4 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Allow touch emulation on devices with native touch. BUG=395531 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179045

Patch Set 1 #

Patch Set 2 : removed hasTouchInputs #

Patch Set 3 : rebase #

Patch Set 4 : rebased #

Patch Set 5 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -41 lines) Patch
M Source/core/inspector/InspectorPageAgent.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 2 3 4 1 chunk +5 lines, -16 lines 0 comments Download
M Source/devtools/front_end/main/OverridesView.js View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/sdk/OverridesSupport.js View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
M Source/devtools/front_end/sdk/Target.js View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/protocol.json View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
dgozman
Take a look please.
6 years, 5 months ago (2014-07-24 13:51:56 UTC) #1
pfeldman
lgtm
6 years, 4 months ago (2014-07-28 11:55:55 UTC) #2
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 4 months ago (2014-07-28 14:58:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/376873004/80001
6 years, 4 months ago (2014-07-28 14:59:08 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 16:04:08 UTC) #5
Message was sent while issue was closed.
Change committed as 179045

Powered by Google App Engine
This is Rietveld 408576698