Updated WebRTC legacy test to not force the GICE ufrag and pwd.

Updated WebRTC legacy test to not force the GICE ufrag and pwd.

These should be generated by the browser instead. I considered
verifying the generated credentials but I think that's better done in
a different test.

R=bemasc@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282311

[phoglund_chromium, 2014-07-08 15:06:10]

tommi: owner stamp
bemasc: main review

[bemasc, 2014-07-08 15:17:39]

Almost perfect.

https://codereview.chromium.org/376863005/diff/1/content/test/data/media/peer...
File content/test/data/media/peerconnection-call.html (left):

https://codereview.chromium.org/376863005/diff/1/content/test/data/media/peer...
content/test/data/media/peerconnection-call.html:822: candidate.candidate =
transformCandidate(candidate.candidate);
I think this should probably also check the format of candidate.candidate,
probably just something like

!!candidate.candidate.match(/username \S+ password \S+/)

[phoglund_chromium, 2014-07-08 15:35:22]

https://codereview.chromium.org/376863005/diff/1/content/test/data/media/peer...
File content/test/data/media/peerconnection-call.html (left):

https://codereview.chromium.org/376863005/diff/1/content/test/data/media/peer...
content/test/data/media/peerconnection-call.html:822: candidate.candidate =
transformCandidate(candidate.candidate);
On 2014/07/08 15:17:38, bemasc wrote:
> I think this should probably also check the format of candidate.candidate,
> probably just something like
> 
> !!candidate.candidate.match(/username \S+ password \S+/)
Hm, doesn't work. This is the value I get for candidate.candidate:

candidate:1510613869 1 udp 2121998079 127.0.0.1 44516 typ host generation 0

[phoglund_chromium, 2014-07-08 15:39:45]

On 2014/07/08 15:35:22, phoglund wrote:
>
https://codereview.chromium.org/376863005/diff/1/content/test/data/media/peer...
> File content/test/data/media/peerconnection-call.html (left):
> 
>
https://codereview.chromium.org/376863005/diff/1/content/test/data/media/peer...
> content/test/data/media/peerconnection-call.html:822: candidate.candidate =
> transformCandidate(candidate.candidate);
> On 2014/07/08 15:17:38, bemasc wrote:
> > I think this should probably also check the format of candidate.candidate,
> > probably just something like
> > 
> > !!candidate.candidate.match(/username \S+ password \S+/)
> Hm, doesn't work. This is the value I get for candidate.candidate:
> 
> candidate:1510613869 1 udp 2121998079 127.0.0.1 44516 typ host generation 0

Because you mean that !!candidate.candidate.match(/username \S+ password \S+/)
should be true when everything is OK right?

[bemasc, 2014-07-09 15:55:51]

lgtm

I now realize there are some other changes that should be added to the gICE
testing, but we don't have to do it all in one CL.

[phoglund_chromium, 2014-07-10 06:55:46]

The CQ bit was checked by phoglund@chromium.org

[phoglund_chromium, 2014-07-10 06:55:50]

The CQ bit was unchecked by phoglund@chromium.org

[phoglund_chromium, 2014-07-10 06:56:17]

xians or tommi: owner stamp please.

[no longer working on chromium, 2014-07-10 07:10:00]

On 2014/07/10 06:56:17, phoglund wrote:
> xians or tommi: owner stamp please.

Lgtm

[phoglund_chromium, 2014-07-10 07:39:21]

The CQ bit was checked by phoglund@chromium.org

[commit-bot: I haz the power, 2014-07-10 07:43:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/phoglund@chromium.org/376863005/1

[commit-bot: I haz the power, 2014-07-10 11:22:43]

Change committed as 282311