Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc

Issue 376863003: Stop manually calling AddRef/Release for AutocompleteController::providers_ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_controller_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc
diff --git a/chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc b/chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc
index ad142a401598ce3b57b0580006ef718f0af8b03d..f74297f4a21021439ced590b8661d398112d500f 100644
--- a/chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc
+++ b/chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc
@@ -94,10 +94,10 @@ class TypeConverter<AutocompleteMatchMojoPtr, AutocompleteMatch> {
template <>
class TypeConverter<AutocompleteResultsForProviderMojoPtr,
- AutocompleteProvider*> {
+ scoped_refptr<AutocompleteProvider> > {
public:
static AutocompleteResultsForProviderMojoPtr ConvertFrom(
- const AutocompleteProvider* input) {
+ const scoped_refptr<AutocompleteProvider>& input) {
AutocompleteResultsForProviderMojoPtr result(
AutocompleteResultsForProviderMojo::New());
result->provider_name = input->GetName();
@@ -140,7 +140,7 @@ void OmniboxUIHandler::OnResultChanged(bool default_match_changed) {
}
result->results_by_provider =
mojo::Array<AutocompleteResultsForProviderMojoPtr>::From(
- *controller_->providers());
+ controller_->providers());
client()->HandleNewAutocompleteResult(result.Pass());
}
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_controller_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698