Stop manually calling AddRef/Release for AutocompleteController::providers_

Stop manually calling AddRef/Release for AutocompleteController::providers_

No need to manually manipulate the ref count when scoped_refptr can be used.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281987

[Peter Kasting, 2014-07-09 01:07:32]

LGTM

https://codereview.chromium.org/376863003/diff/20001/chrome/browser/autocompl...
File chrome/browser/autocomplete/autocomplete_controller.cc (right):

https://codereview.chromium.org/376863003/diff/20001/chrome/browser/autocompl...
chrome/browser/autocomplete/autocomplete_controller.cc:224: providers_.clear(); 
// Not really necessary.
Go ahead and remove this line.

https://codereview.chromium.org/376863003/diff/20001/chrome/browser/autocompl...
File chrome/browser/autocomplete/autocomplete_controller.h (right):

https://codereview.chromium.org/376863003/diff/20001/chrome/browser/autocompl...
chrome/browser/autocomplete/autocomplete_controller.h:50: typedef
std::vector<scoped_refptr<AutocompleteProvider> > Providers;
Any particular reason to declare this here instead of in autocomplete_provider.h
where ACProviders was being declared?  Seems like you could have just updated
that typedef, and eliminated the majority of changes in this CL.

[hashimoto, 2014-07-09 01:57:29]

https://codereview.chromium.org/376863003/diff/20001/chrome/browser/autocompl...
File chrome/browser/autocomplete/autocomplete_controller.cc (right):

https://codereview.chromium.org/376863003/diff/20001/chrome/browser/autocompl...
chrome/browser/autocomplete/autocomplete_controller.cc:224: providers_.clear(); 
// Not really necessary.
On 2014/07/09 01:07:32, Peter Kasting wrote:
> Go ahead and remove this line.

Done.

https://codereview.chromium.org/376863003/diff/20001/chrome/browser/autocompl...
File chrome/browser/autocomplete/autocomplete_controller.h (right):

https://codereview.chromium.org/376863003/diff/20001/chrome/browser/autocompl...
chrome/browser/autocomplete/autocomplete_controller.h:50: typedef
std::vector<scoped_refptr<AutocompleteProvider> > Providers;
On 2014/07/09 01:07:32, Peter Kasting wrote:
> Any particular reason to declare this here instead of in
autocomplete_provider.h
> where ACProviders was being declared?  Seems like you could have just updated
> that typedef, and eliminated the majority of changes in this CL.

This typedef is only used as AutocompleteController::providers_ while
AutocompleteProvider is not interested in this type at all.

[hashimoto, 2014-07-09 04:10:58]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-07-09 04:16:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/376863003/40001

[commit-bot: I haz the power, 2014-07-09 05:36:48]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-09 07:35:30]

Change committed as 281987