Issue 376823005: yama test workaround: Do feature detection, not OS version sniffing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 376823005: yama test workaround: Do feature detection, not OS version sniffing.

Created:
6 years, 5 months ago by Nico

Modified:
6 years, 5 months ago

Reviewers:
Kees Cook

CC:
chromium-reviews, agl, jln+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

yama test workaround: Do feature detection, not OS version sniffing. Requested by keescook on https://codereview.chromium.org/371113003/ BUG=391916

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -10 lines)			Patch
	M	sandbox/linux/services/yama_unittests.cc	View		1 chunk	+2 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

I don't have access to my vm today; I'll test this tomorrow. One disadvantage of ...

6 years, 5 months ago (2014-07-08 17:53:56 UTC) #1

Kees Cook

On 2014/07/08 17:53:56, Nico (away) wrote: > I don't have access to my vm today; ...

6 years, 5 months ago (2014-07-08 20:13:11 UTC) #2

Nico

6 years, 5 months ago (2014-07-08 21:41:10 UTC) #3

On 2014/07/08 20:13:11, Kees Cook wrote:
> On 2014/07/08 17:53:56, Nico (away) wrote:
> > I don't have access to my vm today; I'll test this tomorrow.
> > 
> > One disadvantage of this is that if yama breaks in a future linux update, we
> > won't learn about it from these tests. With the old code it would be
detected.
> 
> Given this, perhaps we should not detect it? Precise will be fixed in the next
> update...

This definitely needs to be detected in some way at the moment, as we're rolling
out 64bit kernels. I don't know how often we install precise updates. If you
prefer, I can check more of the kernel version prefix to ensure the test isn't
suppressed in precise versions with the fix.

Expand Messages | Collapse Messages